From 79e21b5b162d3c2d3fb274b20bfe180c15284893 Mon Sep 17 00:00:00 2001 From: Valentin Rothberg Date: Mon, 8 Aug 2022 11:44:52 +0200 Subject: kube play: sd-notify integration Integrate sd-notify policies into `kube play`. The policies can be configured for all contianers via the `io.containers.sdnotify` annotation or for indidivual containers via the `io.containers.sdnotify/$name` annotation. The `kube play` process will wait for all containers to be ready by waiting for the individual `READY=1` messages which are received via the `pkg/systemd/notifyproxy` proxy mechanism. Also update the simple "container" sd-notify test as it did not fully test the expected behavior which became obvious when adding the new tests. Signed-off-by: Valentin Rothberg --- cmd/podman/kube/play.go | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'cmd/podman') diff --git a/cmd/podman/kube/play.go b/cmd/podman/kube/play.go index 4811bcf4b..07c4b59b9 100644 --- a/cmd/podman/kube/play.go +++ b/cmd/podman/kube/play.go @@ -182,6 +182,10 @@ func playFlags(cmd *cobra.Command) { } func Play(cmd *cobra.Command, args []string) error { + if playOptions.ServiceContainer && !playOptions.StartCLI { // Sanity check to be future proof + return fmt.Errorf("--service-container does not work with --start=stop") + } + // TLS verification in c/image is controlled via a `types.OptionalBool` // which allows for distinguishing among set-true, set-false, unspecified // which is important to implement a sane way of dealing with defaults of -- cgit v1.2.3-54-g00ecf