From cfdfb751a36d8975d56cebe38be682bd9d3308c8 Mon Sep 17 00:00:00 2001 From: Matthew Heon Date: Thu, 15 Mar 2018 16:23:48 -0400 Subject: Address review comments Signed-off-by: Matthew Heon Closes: #503 Approved by: rhatdan --- cmd/podman/restart.go | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) (limited to 'cmd/podman') diff --git a/cmd/podman/restart.go b/cmd/podman/restart.go index f96959a27..84aa5f830 100644 --- a/cmd/podman/restart.go +++ b/cmd/podman/restart.go @@ -58,7 +58,12 @@ func restartCmd(c *cli.Context) error { if err != nil { lastError = errors.Wrapf(err, "unable to get latest container") } else { - lastError = restartCtr(timeout, useTimeout, lastCtr) + ctrTimeout := lastCtr.StopTimeout() + if useTimeout { + ctrTimeout = timeout + } + + lastError = restartCtr(ctrTimeout, lastCtr) } } @@ -72,7 +77,12 @@ func restartCmd(c *cli.Context) error { continue } - if err := restartCtr(timeout, useTimeout, ctr); err != nil { + ctrTimeout := ctr.StopTimeout() + if useTimeout { + ctrTimeout = timeout + } + + if err := restartCtr(ctrTimeout, ctr); err != nil { if lastError != nil { fmt.Fprintln(os.Stderr, lastError) } @@ -84,12 +94,7 @@ func restartCmd(c *cli.Context) error { } // Restart a single container -func restartCtr(cliTimeout uint, useTimeout bool, ctr *libpod.Container) error { - timeout := ctr.StopTimeout() - if useTimeout { - timeout = cliTimeout - } - +func restartCtr(timeout uint, ctr *libpod.Container) error { state, err := ctr.State() if err != nil { return err -- cgit v1.2.3-54-g00ecf