From d72918fe6f19a080892df5f3e87d96d35b7720f4 Mon Sep 17 00:00:00 2001 From: Daniel J Walsh Date: Tue, 20 Oct 2020 16:17:25 -0400 Subject: Podman build should default to not usins stdin Currently we leak stdin into podman builds, which can lead to issues like run commands inside of the container waiting for user input. We should not take input from users other then if the user specifies podman build -f - or podman build -, which are taken care of in other code. Signed-off-by: Daniel J Walsh --- cmd/podman/images/build.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'cmd/podman') diff --git a/cmd/podman/images/build.go b/cmd/podman/images/build.go index ac1b2c848..aa4e87952 100644 --- a/cmd/podman/images/build.go +++ b/cmd/podman/images/build.go @@ -282,8 +282,7 @@ func buildFlagsWrapperToOptions(c *cobra.Command, contextDir string, flags *buil flags.Layers = false } - var stdin, stdout, stderr, reporter *os.File - stdin = os.Stdin + var stdout, stderr, reporter *os.File stdout = os.Stdout stderr = os.Stderr reporter = os.Stderr @@ -422,7 +421,6 @@ func buildFlagsWrapperToOptions(c *cobra.Command, contextDir string, flags *buil ForceRmIntermediateCtrs: flags.ForceRm, IDMappingOptions: idmappingOptions, IIDFile: flags.Iidfile, - In: stdin, Isolation: isolation, Labels: flags.Label, Layers: flags.Layers, -- cgit v1.2.3-54-g00ecf