From 4739fc2d98baf0ccfc46ae3ef770243bbdcea47a Mon Sep 17 00:00:00 2001 From: Matthew Heon Date: Tue, 13 Mar 2018 15:12:52 -0400 Subject: Add test. Move attach code in start back Signed-off-by: Matthew Heon Closes: #482 Approved by: baude --- cmd/podman/start.go | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'cmd') diff --git a/cmd/podman/start.go b/cmd/podman/start.go index 243fe71e2..5053abc07 100644 --- a/cmd/podman/start.go +++ b/cmd/podman/start.go @@ -104,18 +104,8 @@ func startCmd(c *cli.Context) error { if err != nil { return errors.Wrapf(err, "unable to parse annotations in %s", ctr.ID()) } - err = ctr.Start() - if err != nil { - if lastError != nil { - fmt.Fprintln(os.Stderr, lastError) - } - lastError = errors.Wrapf(err, "unable to start %s", container) - continue - } // We only get a terminal session if both a tty was specified in the spec and // -a on the command-line was given. - // Must be done after Start() because we might be restarting - // If so, the attach socket might be removed & recreated if attach && tty { // We increment the wg counter because we need to do the attach wg.Add(1) @@ -131,6 +121,14 @@ func startCmd(c *cli.Context) error { return errors.Errorf("unable to attach to container %s", ctr.ID()) } } + err = ctr.Start() + if err != nil { + if lastError != nil { + fmt.Fprintln(os.Stderr, lastError) + } + lastError = errors.Wrapf(err, "unable to start %s", container) + continue + } if !attach { fmt.Println(ctr.ID()) } @@ -147,6 +145,8 @@ func startCmd(c *cli.Context) error { // Otherwise the container is probably still running if attach && tty { lastError = ctr.Cleanup() + // No need for LastError as we can only have one ctr + // with attach } } return lastError -- cgit v1.2.3-54-g00ecf