From 4216f7b7f492fee80cfc9a7f1deb608096edd890 Mon Sep 17 00:00:00 2001 From: Daniel J Walsh Date: Thu, 16 Sep 2021 05:41:09 -0400 Subject: Add no-trunc support to podman-events Standardize on no-trunc through the code. Alias notruncate where necessary. Standardize on the man page display of no-trunc. Fixes: https://github.com/containers/podman/issues/8941 Signed-off-by: Daniel J Walsh --- cmd/podman/containers/mount.go | 3 ++- cmd/podman/images/history.go | 3 ++- cmd/podman/system/events.go | 5 ++++- cmd/podman/utils/alias.go | 2 ++ 4 files changed, 10 insertions(+), 3 deletions(-) (limited to 'cmd') diff --git a/cmd/podman/containers/mount.go b/cmd/podman/containers/mount.go index 55f6a1c34..0397b456f 100644 --- a/cmd/podman/containers/mount.go +++ b/cmd/podman/containers/mount.go @@ -62,7 +62,8 @@ func mountFlags(cmd *cobra.Command) { flags.StringVar(&mountOpts.Format, formatFlagName, "", "Print the mounted containers in specified format (json)") _ = cmd.RegisterFlagCompletionFunc(formatFlagName, common.AutocompleteFormat(nil)) - flags.BoolVar(&mountOpts.NoTruncate, "notruncate", false, "Do not truncate output") + flags.BoolVar(&mountOpts.NoTruncate, "no-trunc", false, "Do not truncate output") + flags.SetNormalizeFunc(utils.AliasFlags) } func init() { diff --git a/cmd/podman/images/history.go b/cmd/podman/images/history.go index c065acfad..cc7b1b4eb 100644 --- a/cmd/podman/images/history.go +++ b/cmd/podman/images/history.go @@ -11,6 +11,7 @@ import ( "github.com/containers/common/pkg/report" "github.com/containers/podman/v3/cmd/podman/common" "github.com/containers/podman/v3/cmd/podman/registry" + "github.com/containers/podman/v3/cmd/podman/utils" "github.com/containers/podman/v3/pkg/domain/entities" "github.com/docker/go-units" "github.com/pkg/errors" @@ -73,8 +74,8 @@ func historyFlags(cmd *cobra.Command) { flags.BoolVarP(&opts.human, "human", "H", true, "Display sizes and dates in human readable format") flags.BoolVar(&opts.noTrunc, "no-trunc", false, "Do not truncate the output") - flags.BoolVar(&opts.noTrunc, "notruncate", false, "Do not truncate the output") flags.BoolVarP(&opts.quiet, "quiet", "q", false, "Display the numeric IDs only") + flags.SetNormalizeFunc(utils.AliasFlags) } func history(cmd *cobra.Command, args []string) error { diff --git a/cmd/podman/system/events.go b/cmd/podman/system/events.go index 677504cfc..e698e6652 100644 --- a/cmd/podman/system/events.go +++ b/cmd/podman/system/events.go @@ -36,6 +36,7 @@ var ( var ( eventOptions entities.EventsOptions eventFormat string + noTrunc bool ) func init() { @@ -58,6 +59,8 @@ func init() { flags.StringVar(&eventOptions.Since, sinceFlagName, "", "show all events created since timestamp") _ = eventsCommand.RegisterFlagCompletionFunc(sinceFlagName, completion.AutocompleteNone) + flags.BoolVar(&noTrunc, "no-trunc", true, "do not truncate the output") + untilFlagName := "until" flags.StringVar(&eventOptions.Until, untilFlagName, "", "show all events until timestamp") _ = eventsCommand.RegisterFlagCompletionFunc(untilFlagName, completion.AutocompleteNone) @@ -110,7 +113,7 @@ func eventsCmd(cmd *cobra.Command, _ []string) error { } fmt.Println("") default: - fmt.Println(event.ToHumanReadable()) + fmt.Println(event.ToHumanReadable(!noTrunc)) } } diff --git a/cmd/podman/utils/alias.go b/cmd/podman/utils/alias.go index 306e610d9..4d5b625d0 100644 --- a/cmd/podman/utils/alias.go +++ b/cmd/podman/utils/alias.go @@ -23,6 +23,8 @@ func AliasFlags(f *pflag.FlagSet, name string) pflag.NormalizedName { name = "external" case "purge": name = "rm" + case "notruncate": + name = "no-trunc" case "override-arch": name = "arch" case "override-os": -- cgit v1.2.3-54-g00ecf