From e5335fd74c7ed6fe0fa55bf33afbdab23ed687f1 Mon Sep 17 00:00:00 2001 From: Matthew Heon Date: Wed, 5 Dec 2018 09:25:44 -0500 Subject: Remove --sync flag from `podman rm` Per discussion with Dan, it would be better to automatically handle potential runtime errors by automatically syncing if they occur. Retaining the flag for `ps` makes sense, as we won't even be calling the OCI runtime and as such won't see errors if the state desyncs, but rm can be handled automatically. The automatic desync handling code will take some additional work so we'll land this as-is (sync on ps is enough to solve most desync issues). Signed-off-by: Matthew Heon --- cmd/podman/rm.go | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'cmd') diff --git a/cmd/podman/rm.go b/cmd/podman/rm.go index 224df4543..7c0569b78 100644 --- a/cmd/podman/rm.go +++ b/cmd/podman/rm.go @@ -20,10 +20,6 @@ var ( Usage: "Force removal of a running container. The default is false", }, LatestFlag, - cli.BoolFlag{ - Name: "sync", - Usage: "Sync container state with OCI runtime before removing", - }, cli.BoolFlag{ Name: "volumes, v", Usage: "Remove the volumes associated with the container (Not implemented yet)", @@ -77,12 +73,6 @@ func rmCmd(c *cli.Context) error { for _, container := range delContainers { con := container f := func() error { - if c.Bool("sync") { - if err := con.Sync(); err != nil { - return err - } - } - return runtime.RemoveContainer(ctx, con, c.Bool("force")) } -- cgit v1.2.3-54-g00ecf