From db23e1261165bae3dda38bc1f3b6a11573e36417 Mon Sep 17 00:00:00 2001 From: Daniel J Walsh Date: Wed, 7 Oct 2020 15:27:54 -0400 Subject: Add support for external container External containers are containers created outside of Podman. For example Buildah and CRI-O Containers. $ buildah from alpine alpine-working-container $ buildah run alpine-working-container touch /test $ podman container exists --external alpine-working-container $ podman container diff alpine-working-container C /etc A /test Added --external flag to refer to external containers, rather then --storage. Added --external for podman container exists and modified podman ps to use --external rather then --storage. It was felt that --storage would confuse the user into thinking about changing the storage driver or options. --storage is still supported through the use of aliases. Finally podman contianer diff, does not require the --external flag, since it there is little change of users making the mistake, and would just be a pain for the user to remember the flag. podman container exists --external is required because it could fool scripts that rely on the existance of a Podman container, and there is a potential for a partial deletion of a container, which could mess up existing users. Signed-off-by: Daniel J Walsh --- completions/bash/podman | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'completions/bash/podman') diff --git a/completions/bash/podman b/completions/bash/podman index 564d35f67..9ed64ce3a 100644 --- a/completions/bash/podman +++ b/completions/bash/podman @@ -2468,7 +2468,6 @@ _podman_rm() { -i --latest -l - --storage --volumes -v " @@ -2696,7 +2695,7 @@ _podman_ps() { --pod -p --quiet -q --size -s - --storage + --external --namespace --ns --sync " @@ -3168,7 +3167,11 @@ _podman_container_exists() { " local boolean_options=" - " + --external + -h + --help + " + case "$cur" in -*) COMPREPLY=($(compgen -W "$boolean_options $options_with_args" -- "$cur")) -- cgit v1.2.3-54-g00ecf