From ca6ffbccc2b47ffe74bb74ebae5a61504203966c Mon Sep 17 00:00:00 2001 From: Jhon Honce Date: Fri, 6 Jul 2018 10:53:48 -0700 Subject: Refactor unittest for change in history API * test_images.TestImages.test_history changed to allow '' as legal image ID. Previously all layers used the image ID. Now layer 0 reports ''. Signed-off-by: Jhon Honce Closes: #1056 Approved by: jwhonce --- contrib/python/test/test_images.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) (limited to 'contrib/python/test') diff --git a/contrib/python/test/test_images.py b/contrib/python/test/test_images.py index c8c1814dc..c5695b722 100644 --- a/contrib/python/test/test_images.py +++ b/contrib/python/test/test_images.py @@ -1,6 +1,7 @@ import itertools import os import unittest +from collections import Counter from datetime import datetime, timezone from test.podman_testcase import PodmanTestCase @@ -81,9 +82,15 @@ class TestImages(PodmanTestCase): self.assertEqual(actual, self.alpine_image) def test_history(self): - for count, record in enumerate(self.alpine_image.history()): - self.assertEqual(record.id, self.alpine_image.id) - self.assertGreater(count, 0) + records = [] + bucket = Counter() + for record in self.alpine_image.history(): + self.assertIn(record.id, (self.alpine_image.id, '')) + bucket[record.id] += 1 + records.append(record) + + self.assertGreater(bucket[self.alpine_image.id], 0) + self.assertEqual(sum(bucket.values()), len(records)) def test_inspect(self): actual = self.alpine_image.inspect() -- cgit v1.2.3-54-g00ecf