From cf35168f0a9cf457f0622cd89cff84bdbe610d58 Mon Sep 17 00:00:00 2001 From: Eng Zer Jun Date: Thu, 5 May 2022 21:09:41 +0800 Subject: test: use `T.TempDir` to create temporary test directory This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The directory created by `t.TempDir` is automatically removed when the test and all its subtests complete. Prior to this commit, temporary directory created using `ioutil.TempDir` needs to be removed manually by calling `os.RemoveAll`, which is omitted in some tests. The error handling boilerplate e.g. defer func() { if err := os.RemoveAll(dir); err != nil { t.Fatal(err) } } is also tedious, but `t.TempDir` handles this for us nicely. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun --- libpod/container_internal_test.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'libpod/container_internal_test.go') diff --git a/libpod/container_internal_test.go b/libpod/container_internal_test.go index 2b50093b2..05fdba04f 100644 --- a/libpod/container_internal_test.go +++ b/libpod/container_internal_test.go @@ -19,11 +19,7 @@ var hookPath string func TestPostDeleteHooks(t *testing.T) { ctx := context.Background() - dir, err := ioutil.TempDir("", "libpod_test_") - if err != nil { - t.Fatal(err) - } - defer os.RemoveAll(dir) + dir := t.TempDir() statePath := filepath.Join(dir, "state") copyPath := filepath.Join(dir, "copy") @@ -57,7 +53,7 @@ func TestPostDeleteHooks(t *testing.T) { }, }, } - err = c.postDeleteHooks(ctx) + err := c.postDeleteHooks(ctx) if err != nil { t.Fatal(err) } -- cgit v1.2.3-54-g00ecf