From 62f4b0a1955853592c01310a2cf7e0ae041b9566 Mon Sep 17 00:00:00 2001 From: Matthew Heon Date: Thu, 10 Jun 2021 14:12:30 -0400 Subject: Add ExecDied event and use it to retrieve exit codes When making Exec Cleanup processes mandatory, I introduced a race wherein attached exec sessions could be cleaned up and removed by the cleanup process before the frontend had a chance to get their exit code. Fortunately, we've dealt with this issue before in containers, and the same solution can be applied here. I added an event for an exec session's process exiting, `exec_died` (Docker has an identical event, so this actually improves our compatibility there) that includes the exit code of the exec session. If the race happens and the exec session no longer exists when we go to remove it, pick up exit code from the event and exit cleanly. Signed-off-by: Matthew Heon --- libpod/events/config.go | 2 ++ 1 file changed, 2 insertions(+) (limited to 'libpod/events/config.go') diff --git a/libpod/events/config.go b/libpod/events/config.go index 085fa9d52..d88d7b6e3 100644 --- a/libpod/events/config.go +++ b/libpod/events/config.go @@ -127,6 +127,8 @@ const ( Create Status = "create" // Exec ... Exec Status = "exec" + // ExecDied indicates that an exec session in a container died. + ExecDied Status = "exec_died" // Exited indicates that a container's process died Exited Status = "died" // Export ... -- cgit v1.2.3-54-g00ecf