From 7630f1b52efbefec463223e7631bee2ca007ce14 Mon Sep 17 00:00:00 2001 From: Sascha Grunert Date: Thu, 25 Jul 2019 12:45:08 +0200 Subject: Fix possible runtime panic if image history len is zero We now return an empty string for the `Comment` field if an OCI v1 image contains no history. Signed-off-by: Sascha Grunert --- libpod/image/image.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'libpod/image') diff --git a/libpod/image/image.go b/libpod/image/image.go index db50e3dbd..068491f28 100644 --- a/libpod/image/image.go +++ b/libpod/image/image.go @@ -1298,7 +1298,10 @@ func (i *Image) Comment(ctx context.Context, manifestType string) (string, error if err != nil { return "", err } - return ociv1Img.History[0].Comment, nil + if len(ociv1Img.History) > 0 { + return ociv1Img.History[0].Comment, nil + } + return "", nil } // Save writes a container image to the filesystem -- cgit v1.2.3-54-g00ecf