From eba89259a5938f047d78b74c5bbbc908f8ff4be8 Mon Sep 17 00:00:00 2001 From: Matthew Heon Date: Fri, 4 Jan 2019 14:15:08 -0500 Subject: Address lingering review comments from SHM locking PR Signed-off-by: Matthew Heon --- libpod/lock/shm_lock_manager_linux.go | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'libpod/lock/shm_lock_manager_linux.go') diff --git a/libpod/lock/shm_lock_manager_linux.go b/libpod/lock/shm_lock_manager_linux.go index 3e8f4f3d2..94dfd7dd7 100644 --- a/libpod/lock/shm_lock_manager_linux.go +++ b/libpod/lock/shm_lock_manager_linux.go @@ -3,7 +3,10 @@ package lock import ( + "syscall" + "github.com/containers/libpod/libpod/lock/shm" + "github.com/pkg/errors" ) // SHMLockManager manages shared memory locks. @@ -60,6 +63,11 @@ func (m *SHMLockManager) RetrieveLock(id uint32) (Locker, error) { lock.lockID = id lock.manager = m + if id >= m.locks.GetMaxLocks() { + return nil, errors.Wrapf(syscall.EINVAL, "lock ID %d is too large - max lock size is %d", + id, m.locks.GetMaxLocks()-1) + } + return lock, nil } -- cgit v1.2.3-54-g00ecf