From 9e6928570459ba5451f2128a9391bbb48acefc1e Mon Sep 17 00:00:00 2001 From: Peter Hunt Date: Tue, 23 Jul 2019 11:16:34 -0400 Subject: only use stdin if specified Signed-off-by: Peter Hunt --- pkg/adapter/containers_remote.go | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) (limited to 'pkg/adapter/containers_remote.go') diff --git a/pkg/adapter/containers_remote.go b/pkg/adapter/containers_remote.go index 0373913d0..751c184b3 100644 --- a/pkg/adapter/containers_remote.go +++ b/pkg/adapter/containers_remote.go @@ -1057,12 +1057,8 @@ func (r *LocalRuntime) ExecContainer(ctx context.Context, cli *cliconfig.ExecVal ecChan := make(chan int, 1) errChan := configureVarlinkAttachStdio(r.Conn.Reader, r.Conn.Writer, inputStream, os.Stdout, oldTermState, resize, ecChan) - select { - case ec = <-ecChan: - break - case err = <-errChan: - break - } + ec = <-ecChan + err = <-errChan return ec, err } @@ -1095,13 +1091,15 @@ func configureVarlinkAttachStdio(reader *bufio.Reader, writer *bufio.Writer, std } }() - // Takes stdinput and sends it over the wire after being encoded - go func() { - if _, err := io.Copy(varlinkStdinWriter, stdin); err != nil { - defer restoreTerminal(oldTermState) - errChan <- err - } + if stdin != nil { + // Takes stdinput and sends it over the wire after being encoded + go func() { + if _, err := io.Copy(varlinkStdinWriter, stdin); err != nil { + defer restoreTerminal(oldTermState) + errChan <- err + } - }() + }() + } return errChan } -- cgit v1.2.3-54-g00ecf