From 0785d6af157f815b93b2c7b105dbece2dbb7fefa Mon Sep 17 00:00:00 2001 From: Daniel J Walsh Date: Thu, 30 Jul 2020 14:00:44 -0400 Subject: Handle single character images Currently you can only specify multiple character for image names when executing podman-remote commit podman-remote commit a b Will complete, but will save the image without a name. podman-remote commit a bb Works. This PR fixes and now returns an error if the user doees not specify an image name to commit to. Signed-off-by: Daniel J Walsh --- pkg/api/handlers/libpod/images.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'pkg/api/handlers/libpod/images.go') diff --git a/pkg/api/handlers/libpod/images.go b/pkg/api/handlers/libpod/images.go index 3421f0836..d47f27134 100644 --- a/pkg/api/handlers/libpod/images.go +++ b/pkg/api/handlers/libpod/images.go @@ -594,11 +594,9 @@ func CommitContainer(w http.ResponseWriter, r *http.Request) { return } - // I know mitr hates this ... but doing for now - if len(query.Repo) > 1 { + if len(query.Repo) > 0 { destImage = fmt.Sprintf("%s:%s", query.Repo, tag) } - commitImage, err := ctr.Commit(r.Context(), destImage, options) if err != nil && !strings.Contains(err.Error(), "is not running") { utils.Error(w, "Something went wrong.", http.StatusInternalServerError, errors.Wrapf(err, "CommitFailure")) -- cgit v1.2.3-54-g00ecf