From bdccdd2265340d48a0ba868d8c312fdd3172f1c3 Mon Sep 17 00:00:00 2001 From: Ed Santiago Date: Tue, 11 Feb 2020 09:13:53 -0700 Subject: API v2: pods: fix two incorrect return codes 1) /pods//exists - is documented to return 204, and that's the correct value, but until now it has been returning 200. 2) /pods/create - return 409 (conflict), not 500, when pod already exists Also: in WriteResponse(), if code is 204 (No Content) or 304 (Not Modified), emit the status code only but no content-type headers nor content. Signed-off-by: Ed Santiago --- pkg/api/server/register_pods.go | 2 ++ 1 file changed, 2 insertions(+) (limited to 'pkg/api/server/register_pods.go') diff --git a/pkg/api/server/register_pods.go b/pkg/api/server/register_pods.go index 5c7b51871..974568d47 100644 --- a/pkg/api/server/register_pods.go +++ b/pkg/api/server/register_pods.go @@ -41,6 +41,8 @@ func (s *APIServer) registerPodsHandlers(r *mux.Router) error { // type: string // 400: // $ref: "#/responses/BadParamError" + // 409: + // description: pod already exists // 500: // $ref: "#/responses/InternalError" r.Handle(VersionedPath("/libpod/pods/prune"), APIHandler(s.Context, libpod.PodPrune)).Methods(http.MethodPost) -- cgit v1.2.3-54-g00ecf