From f1eaccedfa08455d699d00dcda63b95aeb34833e Mon Sep 17 00:00:00 2001 From: Brent Baude Date: Thu, 30 Jan 2020 12:40:19 -0600 Subject: fix longname handling for bindings the api needs to account for image input where the image is encoded as a fqd image name. Signed-off-by: Brent Baude --- pkg/bindings/connection.go | 2 +- pkg/bindings/test/images_test.go | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'pkg/bindings') diff --git a/pkg/bindings/connection.go b/pkg/bindings/connection.go index 2e5fc9cb8..116af9709 100644 --- a/pkg/bindings/connection.go +++ b/pkg/bindings/connection.go @@ -116,7 +116,7 @@ func (c *Connection) DoRequest(httpBody io.Reader, httpMethod, endpoint string, safePathValues := make([]interface{}, len(pathValues)) // Make sure path values are http url safe for i, pv := range pathValues { - safePathValues[i] = url.QueryEscape(pv) + safePathValues[i] = url.PathEscape(pv) } // Lets eventually use URL for this which might lead to safer // usage diff --git a/pkg/bindings/test/images_test.go b/pkg/bindings/test/images_test.go index 2906d55cd..227f28d16 100644 --- a/pkg/bindings/test/images_test.go +++ b/pkg/bindings/test/images_test.go @@ -67,10 +67,10 @@ var _ = Describe("Podman images", func() { // Inspect with partial ID _, err = images.GetImage(connText, data.ID[0:12], nil) Expect(err).To(BeNil()) - // Inspect by ID + //Inspect by long name should work, it doesnt (yet) i think it needs to be html escaped - //_, err = images.GetImage(connText, alpine, nil) - //Expect(err).To(BeNil()) + _, err = images.GetImage(connText, alpine, nil) + Expect(err).To(BeNil()) }) It("remove image", func() { // Remove invalid image should be a 404 -- cgit v1.2.3-54-g00ecf