From b3f9559c87421701a026f62ca277e568158cccc0 Mon Sep 17 00:00:00 2001 From: Nikolay Edigaryev Date: Thu, 18 Feb 2021 01:09:21 +0300 Subject: bindings: support simple types that implement fmt.Stringer interface Signed-off-by: Nikolay Edigaryev --- pkg/bindings/util/util.go | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'pkg/bindings') diff --git a/pkg/bindings/util/util.go b/pkg/bindings/util/util.go index 6296fc22f..2d65ae9fd 100644 --- a/pkg/bindings/util/util.go +++ b/pkg/bindings/util/util.go @@ -2,6 +2,7 @@ package util import ( "errors" + "fmt" "net/url" "reflect" "strconv" @@ -11,14 +12,25 @@ import ( ) func IsSimpleType(f reflect.Value) bool { + switch f.Interface().(type) { + case fmt.Stringer: + return true + } + switch f.Kind() { case reflect.Bool, reflect.Int, reflect.Int64, reflect.Uint, reflect.Uint64, reflect.String: return true } + return false } func SimpleTypeToParam(f reflect.Value) string { + switch cast := f.Interface().(type) { + case fmt.Stringer: + return cast.String() + } + switch f.Kind() { case reflect.Bool: return strconv.FormatBool(f.Bool()) @@ -31,6 +43,7 @@ func SimpleTypeToParam(f reflect.Value) string { case reflect.String: return f.String() } + panic("the input parameter is not a simple type") } -- cgit v1.2.3-54-g00ecf From e022c19753182cfb85f8f49354d493ee3a3147a3 Mon Sep 17 00:00:00 2001 From: Nikolay Edigaryev Date: Thu, 18 Feb 2021 01:43:23 +0300 Subject: Don't switch on a single case Signed-off-by: Nikolay Edigaryev --- pkg/bindings/util/util.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'pkg/bindings') diff --git a/pkg/bindings/util/util.go b/pkg/bindings/util/util.go index 2d65ae9fd..c1961308e 100644 --- a/pkg/bindings/util/util.go +++ b/pkg/bindings/util/util.go @@ -12,8 +12,7 @@ import ( ) func IsSimpleType(f reflect.Value) bool { - switch f.Interface().(type) { - case fmt.Stringer: + if _, ok := f.Interface().(fmt.Stringer); ok { return true } @@ -26,9 +25,8 @@ func IsSimpleType(f reflect.Value) bool { } func SimpleTypeToParam(f reflect.Value) string { - switch cast := f.Interface().(type) { - case fmt.Stringer: - return cast.String() + if s, ok := f.Interface().(fmt.Stringer); ok { + return s.String() } switch f.Kind() { -- cgit v1.2.3-54-g00ecf