From 462cb3370daa0721368ccd91a122a7f9900dfedf Mon Sep 17 00:00:00 2001 From: Valentin Rothberg Date: Wed, 25 May 2022 12:35:01 +0200 Subject: pkg/bindings/containers/archive.go: drop TODO We are already passed 4.0 and a wrapper like this really does not hurt. Signed-off-by: Valentin Rothberg --- pkg/bindings/containers/archive.go | 2 -- 1 file changed, 2 deletions(-) (limited to 'pkg/bindings') diff --git a/pkg/bindings/containers/archive.go b/pkg/bindings/containers/archive.go index 4f4b5a36a..dd489d6f1 100644 --- a/pkg/bindings/containers/archive.go +++ b/pkg/bindings/containers/archive.go @@ -55,8 +55,6 @@ func CopyFromArchive(ctx context.Context, nameOrID string, path string, reader i } // CopyFromArchiveWithOptions copy files into container -// -// FIXME: remove this function and make CopyFromArchive accept the option as the last parameter in podman 4.0 func CopyFromArchiveWithOptions(ctx context.Context, nameOrID string, path string, reader io.Reader, options *CopyOptions) (entities.ContainerCopyFunc, error) { conn, err := bindings.GetClient(ctx) if err != nil { -- cgit v1.2.3-54-g00ecf From c9279d4d933dd56653ddf50d5a2482439e8f3648 Mon Sep 17 00:00:00 2001 From: Valentin Rothberg Date: Wed, 25 May 2022 12:36:00 +0200 Subject: pkg/bindings/play/play.go: drop TODO message As already done in a previous commit: a global system context does not make sense for bindings, so remove the message. Signed-off-by: Valentin Rothberg --- pkg/bindings/play/play.go | 1 - 1 file changed, 1 deletion(-) (limited to 'pkg/bindings') diff --git a/pkg/bindings/play/play.go b/pkg/bindings/play/play.go index 8058a8514..0261b0250 100644 --- a/pkg/bindings/play/play.go +++ b/pkg/bindings/play/play.go @@ -46,7 +46,6 @@ func KubeWithBody(ctx context.Context, body io.Reader, options *KubeOptions) (*e params.Set("start", strconv.FormatBool(options.GetStart())) } - // TODO: have a global system context we can pass around (1st argument) header, err := auth.MakeXRegistryAuthHeader(&types.SystemContext{AuthFilePath: options.GetAuthfile()}, options.GetUsername(), options.GetPassword()) if err != nil { return nil, err -- cgit v1.2.3-54-g00ecf