From a6046dceeff21bbeea71c0ab5c3d78ff931aa019 Mon Sep 17 00:00:00 2001
From: Daniel J Walsh <dwalsh@redhat.com>
Date: Mon, 4 Jan 2021 13:31:57 -0500
Subject: Remove the ability to use [name:tag] in podman load command

Docker does not support this, and it is confusing what to do if
the image has more then one tag.  We are dropping support for this
in podman 3.0

Fixes: https://github.com/containers/podman/issues/7387

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
---
 pkg/domain/entities/images.go     |  2 --
 pkg/domain/infra/abi/images.go    | 14 +-------------
 pkg/domain/infra/tunnel/images.go |  7 +------
 3 files changed, 2 insertions(+), 21 deletions(-)

(limited to 'pkg/domain')

diff --git a/pkg/domain/entities/images.go b/pkg/domain/entities/images.go
index d5f88502a..0805152c3 100644
--- a/pkg/domain/entities/images.go
+++ b/pkg/domain/entities/images.go
@@ -256,8 +256,6 @@ type ImageInspectReport struct {
 }
 
 type ImageLoadOptions struct {
-	Name            string
-	Tag             string
 	Input           string
 	Quiet           bool
 	SignaturePolicy string
diff --git a/pkg/domain/infra/abi/images.go b/pkg/domain/infra/abi/images.go
index 3487dc3f4..1c233d9d5 100644
--- a/pkg/domain/infra/abi/images.go
+++ b/pkg/domain/infra/abi/images.go
@@ -453,19 +453,7 @@ func (ir *ImageEngine) Load(ctx context.Context, opts entities.ImageLoadOptions)
 	if err != nil {
 		return nil, err
 	}
-	names := strings.Split(name, ",")
-	if len(names) <= 1 {
-		newImage, err := ir.Libpod.ImageRuntime().NewFromLocal(name)
-		if err != nil {
-			return nil, errors.Wrap(err, "image loaded but no additional tags were created")
-		}
-		if len(opts.Name) > 0 {
-			if err := newImage.TagImage(fmt.Sprintf("%s:%s", opts.Name, opts.Tag)); err != nil {
-				return nil, errors.Wrapf(err, "error adding %q to image %q", opts.Name, newImage.InputName)
-			}
-		}
-	}
-	return &entities.ImageLoadReport{Names: names}, nil
+	return &entities.ImageLoadReport{Names: strings.Split(name, ",")}, nil
 }
 
 func (ir *ImageEngine) Import(ctx context.Context, opts entities.ImageImportOptions) (*entities.ImageImportReport, error) {
diff --git a/pkg/domain/infra/tunnel/images.go b/pkg/domain/infra/tunnel/images.go
index fba60235e..8ab832599 100644
--- a/pkg/domain/infra/tunnel/images.go
+++ b/pkg/domain/infra/tunnel/images.go
@@ -215,12 +215,7 @@ func (ir *ImageEngine) Load(ctx context.Context, opts entities.ImageLoadOptions)
 	if fInfo.IsDir() {
 		return nil, errors.Errorf("remote client supports archives only but %q is a directory", opts.Input)
 	}
-	ref := opts.Name
-	if len(opts.Tag) > 0 {
-		ref += ":" + opts.Tag
-	}
-	options := new(images.LoadOptions).WithReference(ref)
-	return images.Load(ir.ClientCtx, f, options)
+	return images.Load(ir.ClientCtx, f)
 }
 
 func (ir *ImageEngine) Import(ctx context.Context, opts entities.ImageImportOptions) (*entities.ImageImportReport, error) {
-- 
cgit v1.2.3-54-g00ecf