From 0b1c45bc542636d48abcc3980baa02b9a65f57a9 Mon Sep 17 00:00:00 2001 From: Paul Holzinger Date: Wed, 15 Sep 2021 15:36:00 +0200 Subject: container runlabel remove image tag from name When no name is given for podman container runlabel it will default to the image base name. However this can contain a tag. Since podman does not accept container names with a colon the run command will fail if it contains something like `podman run --name NAME ...`. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2004263 Signed-off-by: Paul Holzinger --- pkg/domain/infra/abi/containers_runlabel.go | 3 +++ 1 file changed, 3 insertions(+) (limited to 'pkg/domain') diff --git a/pkg/domain/infra/abi/containers_runlabel.go b/pkg/domain/infra/abi/containers_runlabel.go index d448627dc..435baa8c8 100644 --- a/pkg/domain/infra/abi/containers_runlabel.go +++ b/pkg/domain/infra/abi/containers_runlabel.go @@ -133,6 +133,9 @@ func generateRunlabelCommand(runlabel string, img *libimage.Image, inputName str } splitImageName := strings.Split(normalize, "/") name = splitImageName[len(splitImageName)-1] + // make sure to remove the tag from the image name, otherwise the name cannot + // be used as container name because a colon is an illegal character + name = strings.SplitN(name, ":", 2)[0] } // Append the user-specified arguments to the runlabel (command). -- cgit v1.2.3-54-g00ecf