From 720eb85ba55d8c825262e9b2e058ec8a8e0e4d9f Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano Date: Thu, 23 Aug 2018 23:02:04 +0200 Subject: rootless: fix exec We cannot re-exec into a new user namespace to gain privileges and access an existing as the new namespace is not the owner of the existing container. "unshare" is used to join the user namespace of the target container. The current implementation assumes that the main process of the container didn't create a new user namespace. Since in the setup phase we are not running with euid=0, we must skip the setup for containers/storage. Closes: https://github.com/containers/libpod/issues/1329 Signed-off-by: Giuseppe Scrivano Closes: #1331 Approved by: rhatdan --- pkg/rootless/rootless_linux.go | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'pkg/rootless/rootless_linux.go') diff --git a/pkg/rootless/rootless_linux.go b/pkg/rootless/rootless_linux.go index 490ddc33e..26f4b0b18 100644 --- a/pkg/rootless/rootless_linux.go +++ b/pkg/rootless/rootless_linux.go @@ -34,6 +34,20 @@ func IsRootless() bool { return os.Getuid() != 0 || os.Getenv("_LIBPOD_USERNS_CONFIGURED") != "" } +var ( + skipStorageSetup = false +) + +// SetSkipStorageSetup tells the runtime to not setup containers/storage +func SetSkipStorageSetup(v bool) { + skipStorageSetup = v +} + +// SkipStorageSetup tells if we should skip the containers/storage setup +func SkipStorageSetup() bool { + return skipStorageSetup +} + // GetRootlessUID returns the UID of the user in the parent userNS func GetRootlessUID() int { uidEnv := os.Getenv("_LIBPOD_ROOTLESS_UID") -- cgit v1.2.3-54-g00ecf