From ecd245d8fdfd9f611bd23cebf93c2c23914e5653 Mon Sep 17 00:00:00 2001
From: Brent Baude <bbaude@redhat.com>
Date: Mon, 25 Apr 2022 14:48:39 -0500
Subject: Unit tests for pkg/specgenutil pkg/signal

Add some lightweight unit tests to the arsenal.

Signed-off-by: Brent Baude <bbaude@redhat.com>
---
 pkg/signal/signal_common_test.go | 120 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 120 insertions(+)
 create mode 100644 pkg/signal/signal_common_test.go

(limited to 'pkg/signal')

diff --git a/pkg/signal/signal_common_test.go b/pkg/signal/signal_common_test.go
new file mode 100644
index 000000000..c4ae6b389
--- /dev/null
+++ b/pkg/signal/signal_common_test.go
@@ -0,0 +1,120 @@
+package signal
+
+import (
+	"syscall"
+	"testing"
+)
+
+func TestParseSignal(t *testing.T) {
+	type args struct {
+		rawSignal string
+	}
+	tests := []struct {
+		name    string
+		args    args
+		want    syscall.Signal
+		wantErr bool
+	}{
+		{
+			name: "KILL to SIGKILL",
+			args: args{
+				rawSignal: "KILL",
+			},
+			want:    syscall.SIGKILL,
+			wantErr: false,
+		},
+		{
+			name: "Case doesnt matter",
+			args: args{
+				rawSignal: "kIlL",
+			},
+			want:    syscall.SIGKILL,
+			wantErr: false,
+		},
+		{
+			name: "Garbage signal",
+			args: args{
+				rawSignal: "FOO",
+			},
+			want:    -1,
+			wantErr: true,
+		},
+		{
+			name: "Signal with prepended SIG",
+			args: args{
+				rawSignal: "SIGKILL",
+			},
+			want:    syscall.SIGKILL,
+			wantErr: false,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := ParseSignal(tt.args.rawSignal)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("ParseSignal() error = %v, wantErr %v", err, tt.wantErr)
+				return
+			}
+			if got != tt.want {
+				t.Errorf("ParseSignal() got = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}
+
+func TestParseSignalNameOrNumber(t *testing.T) {
+	type args struct {
+		rawSignal string
+	}
+	tests := []struct {
+		name    string
+		args    args
+		want    syscall.Signal
+		wantErr bool
+	}{
+		{
+			name: "Kill should work",
+			args: args{
+				rawSignal: "kill",
+			},
+			want:    syscall.SIGKILL,
+			wantErr: false,
+		},
+		{
+			name: "9 for kill should work",
+			args: args{
+				rawSignal: "9",
+			},
+			want:    syscall.SIGKILL,
+			wantErr: false,
+		},
+		{
+			name: "Non-defined signal number should work",
+			args: args{
+				rawSignal: "923",
+			},
+			want:    923,
+			wantErr: false,
+		},
+		{
+			name: "garbage should fail",
+			args: args{
+				rawSignal: "foo",
+			},
+			want:    -1,
+			wantErr: true,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := ParseSignalNameOrNumber(tt.args.rawSignal)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("ParseSignalNameOrNumber() error = %v, wantErr %v", err, tt.wantErr)
+				return
+			}
+			if got != tt.want {
+				t.Errorf("ParseSignalNameOrNumber() got = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}
-- 
cgit v1.2.3-54-g00ecf