From cf35168f0a9cf457f0622cd89cff84bdbe610d58 Mon Sep 17 00:00:00 2001 From: Eng Zer Jun Date: Thu, 5 May 2022 21:09:41 +0800 Subject: test: use `T.TempDir` to create temporary test directory This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The directory created by `t.TempDir` is automatically removed when the test and all its subtests complete. Prior to this commit, temporary directory created using `ioutil.TempDir` needs to be removed manually by calling `os.RemoveAll`, which is omitted in some tests. The error handling boilerplate e.g. defer func() { if err := os.RemoveAll(dir); err != nil { t.Fatal(err) } } is also tedious, but `t.TempDir` handles this for us nicely. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun --- pkg/specgen/generate/kube/play_test.go | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) (limited to 'pkg/specgen') diff --git a/pkg/specgen/generate/kube/play_test.go b/pkg/specgen/generate/kube/play_test.go index 448522c2a..e01d62b08 100644 --- a/pkg/specgen/generate/kube/play_test.go +++ b/pkg/specgen/generate/kube/play_test.go @@ -3,9 +3,7 @@ package kube import ( "encoding/json" "fmt" - "io/ioutil" "math" - "os" "runtime" "strconv" "testing" @@ -39,9 +37,7 @@ func createSecrets(t *testing.T, d string) *secrets.SecretsManager { } func TestEnvVarsFrom(t *testing.T) { - d, err := ioutil.TempDir("", "secrets") - assert.NoError(t, err) - defer os.RemoveAll(d) + d := t.TempDir() secretsManager := createSecrets(t, d) tests := []struct { @@ -191,9 +187,7 @@ func TestEnvVarsFrom(t *testing.T) { } func TestEnvVarValue(t *testing.T) { - d, err := ioutil.TempDir("", "secrets") - assert.NoError(t, err) - defer os.RemoveAll(d) + d := t.TempDir() secretsManager := createSecrets(t, d) stringNumCPUs := strconv.Itoa(runtime.NumCPU()) -- cgit v1.2.3-54-g00ecf