From 61a226fbd51de015e1753df451a2c67a689caf69 Mon Sep 17 00:00:00 2001
From: baude <bbaude@redhat.com>
Date: Tue, 24 Sep 2019 13:43:44 -0500
Subject: conditionally send stdin on remote run

when running a container remotely, we should only be sending stdin when
running with --interactive; otherwise use nil.

Fixes: #4095

Signed-off-by: baude <bbaude@redhat.com>
---
 pkg/varlinkapi/attach.go | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'pkg/varlinkapi')

diff --git a/pkg/varlinkapi/attach.go b/pkg/varlinkapi/attach.go
index 3bd487849..f8557ae0c 100644
--- a/pkg/varlinkapi/attach.go
+++ b/pkg/varlinkapi/attach.go
@@ -65,7 +65,9 @@ func (i *LibpodAPI) Attach(call iopodman.VarlinkCall, name string, detachKeys st
 	}
 
 	// ACK the client upgrade request
-	call.ReplyAttach()
+	if err := call.ReplyAttach(); err != nil {
+		return call.ReplyErrorOccurred(err.Error())
+	}
 
 	reader, writer, _, pw, streams := setupStreams(call)
 
-- 
cgit v1.2.3-54-g00ecf