From de9a394fcff19ae4422a3f65502c8790787351fd Mon Sep 17 00:00:00 2001 From: Matthew Heon Date: Thu, 5 Sep 2019 10:00:50 -0400 Subject: Correctly report errors on unmounting SHM When we fail to remove a container's SHM, that's an error, and we need to report it as such. This may be part of our lingering storage woes. Also, remove MNT_DETACH. It may be another cause of the storage removal failures. Signed-off-by: Matthew Heon --- pkg/varlinkapi/volumes.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'pkg/varlinkapi') diff --git a/pkg/varlinkapi/volumes.go b/pkg/varlinkapi/volumes.go index a27950b21..6dd86d831 100644 --- a/pkg/varlinkapi/volumes.go +++ b/pkg/varlinkapi/volumes.go @@ -67,8 +67,7 @@ func (i *LibpodAPI) GetVolumes(call iopodman.VarlinkCall, args []string, all boo Labels: v.Labels(), MountPoint: v.MountPoint(), Name: v.Name(), - // TODO change types here to be correct - //Options: v.Options(), + Options: v.Options(), } volumes = append(volumes, newVol) } -- cgit v1.2.3-54-g00ecf