From 31604b43d13c93bc730b07227ed0c39a7b3314cd Mon Sep 17 00:00:00 2001 From: Paul Holzinger Date: Tue, 14 Sep 2021 11:27:12 +0200 Subject: Revert "logs: adjust handling around partial log messages" This reverts commit 21f396de6f5024abbf6edd2ca63edcb1525eefcc. Changing the log endpoint is a breaking change we should not do in 3.4. [NO TESTS NEEDED] Signed-off-by: Paul Holzinger --- pkg/api/handlers/compat/containers_logs.go | 4 +++- pkg/domain/infra/tunnel/containers.go | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) (limited to 'pkg') diff --git a/pkg/api/handlers/compat/containers_logs.go b/pkg/api/handlers/compat/containers_logs.go index 4adcaa511..d73b02b47 100644 --- a/pkg/api/handlers/compat/containers_logs.go +++ b/pkg/api/handlers/compat/containers_logs.go @@ -153,7 +153,9 @@ func LogsFromContainer(w http.ResponseWriter, r *http.Request) { } frame.WriteString(line.Msg) - if !line.Partial() { + // Log lines in the compat layer require adding EOL + // https://github.com/containers/podman/issues/8058 + if !utils.IsLibpodRequest(r) { frame.WriteString("\n") } diff --git a/pkg/domain/infra/tunnel/containers.go b/pkg/domain/infra/tunnel/containers.go index 81ddce42f..b638bfe24 100644 --- a/pkg/domain/infra/tunnel/containers.go +++ b/pkg/domain/infra/tunnel/containers.go @@ -404,11 +404,11 @@ func (ic *ContainerEngine) ContainerLogs(_ context.Context, nameOrIDs []string, return err case line := <-stdoutCh: if opts.StdoutWriter != nil { - _, _ = io.WriteString(opts.StdoutWriter, line) + _, _ = io.WriteString(opts.StdoutWriter, line+"\n") } case line := <-stderrCh: if opts.StderrWriter != nil { - _, _ = io.WriteString(opts.StderrWriter, line) + _, _ = io.WriteString(opts.StderrWriter, line+"\n") } } } -- cgit v1.2.3-54-g00ecf