From 955aaccc55218cd0022a1180df4c15bb27674a8f Mon Sep 17 00:00:00 2001 From: troyready Date: Wed, 10 Mar 2021 19:16:03 -0800 Subject: fix use with localhost (testing) Signed-off-by: troyready --- pkg/api/handlers/compat/auth.go | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) (limited to 'pkg') diff --git a/pkg/api/handlers/compat/auth.go b/pkg/api/handlers/compat/auth.go index e914301f4..2c152fbc2 100644 --- a/pkg/api/handlers/compat/auth.go +++ b/pkg/api/handlers/compat/auth.go @@ -16,6 +16,13 @@ import ( "github.com/pkg/errors" ) +func stripAddressOfScheme(address string) string { + for _, s := range []string{"https", "http"} { + address = strings.TrimPrefix(address, s+"://") + } + return address +} + func Auth(w http.ResponseWriter, r *http.Request) { var authConfig docker.AuthConfig err := json.NewDecoder(r.Body).Decode(&authConfig) @@ -25,7 +32,7 @@ func Auth(w http.ResponseWriter, r *http.Request) { } skipTLS := types.NewOptionalBool(false) - if strings.HasPrefix(authConfig.ServerAddress, "http://localhost/") || strings.HasPrefix(authConfig.ServerAddress, "http://localhost:") { + if strings.HasPrefix(authConfig.ServerAddress, "https://localhost/") || strings.HasPrefix(authConfig.ServerAddress, "https://localhost:") || strings.HasPrefix(authConfig.ServerAddress, "localhost:") { // support for local testing skipTLS = types.NewOptionalBool(true) } @@ -37,7 +44,8 @@ func Auth(w http.ResponseWriter, r *http.Request) { DockerInsecureSkipTLSVerify: skipTLS, SystemRegistriesConfPath: registries.SystemRegistriesConfPath(), } - if err := DockerClient.CheckAuth(context.Background(), &sysCtx, authConfig.Username, authConfig.Password, authConfig.ServerAddress); err == nil { + registry := stripAddressOfScheme(authConfig.ServerAddress) + if err := DockerClient.CheckAuth(context.Background(), &sysCtx, authConfig.Username, authConfig.Password, registry); err == nil { utils.WriteResponse(w, http.StatusOK, entities.AuthReport{ IdentityToken: "", Status: "Login Succeeded", -- cgit v1.2.3-54-g00ecf