From c0e07234631cfcea1d6724c05606964a4d833f39 Mon Sep 17 00:00:00 2001 From: Paul Holzinger Date: Tue, 18 Jan 2022 16:17:53 +0100 Subject: rename --cni-config-dir to --network-config-dir Since this option will also be used for netavark we should rename it to something more generic. It is important that --cni-config-dir still works otherwise we could break existing container cleanup commands. Signed-off-by: Paul Holzinger --- pkg/bindings/test/common_test.go | 2 +- pkg/domain/infra/runtime_libpod.go | 2 +- pkg/specgenutil/util.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'pkg') diff --git a/pkg/bindings/test/common_test.go b/pkg/bindings/test/common_test.go index d1a07598e..f51e5f404 100644 --- a/pkg/bindings/test/common_test.go +++ b/pkg/bindings/test/common_test.go @@ -86,7 +86,7 @@ func (b *bindingTest) runPodman(command []string) *gexec.Session { } val, ok = os.LookupEnv("CNI_CONFIG_DIR") if ok { - cmd = append(cmd, "--cni-config-dir", val) + cmd = append(cmd, "--network-config-dir", val) } val, ok = os.LookupEnv("CONMON") if ok { diff --git a/pkg/domain/infra/runtime_libpod.go b/pkg/domain/infra/runtime_libpod.go index 519af5ab7..f9ceb9305 100644 --- a/pkg/domain/infra/runtime_libpod.go +++ b/pkg/domain/infra/runtime_libpod.go @@ -223,7 +223,7 @@ func getRuntime(ctx context.Context, fs *flag.FlagSet, opts *engineOpts) (*libpo // TODO flag to set libpod static dir? // TODO flag to set libpod tmp dir? - if fs.Changed("cni-config-dir") { + if fs.Changed("network-config-dir") { options = append(options, libpod.WithCNIConfigDir(cfg.Network.NetworkConfigDir)) } if fs.Changed("default-mounts-file") { diff --git a/pkg/specgenutil/util.go b/pkg/specgenutil/util.go index 0a980a576..80d31398b 100644 --- a/pkg/specgenutil/util.go +++ b/pkg/specgenutil/util.go @@ -279,7 +279,7 @@ func CreateExitCommandArgs(storageConfig storageTypes.StoreOptions, config *conf "--log-level", logrus.GetLevel().String(), "--cgroup-manager", config.Engine.CgroupManager, "--tmpdir", config.Engine.TmpDir, - "--cni-config-dir", config.Network.NetworkConfigDir, + "--network-config-dir", config.Network.NetworkConfigDir, "--network-backend", config.Network.NetworkBackend, } if config.Engine.OCIRuntime != "" { -- cgit v1.2.3-54-g00ecf