From c657dc4fdbca4b331d69e0910261e2cb11e2a629 Mon Sep 17 00:00:00 2001 From: Daniel J Walsh Date: Tue, 18 Dec 2018 11:44:19 -0500 Subject: Switch all referencs to image.ContainerConfig to image.Config This will more closely match what Docker is doing. Signed-off-by: Daniel J Walsh --- pkg/inspect/inspect.go | 42 ++++++++++++++++++------------------- pkg/varlinkapi/containers_create.go | 12 +++++------ 2 files changed, 27 insertions(+), 27 deletions(-) (limited to 'pkg') diff --git a/pkg/inspect/inspect.go b/pkg/inspect/inspect.go index 5bdcf677f..dcb7738be 100644 --- a/pkg/inspect/inspect.go +++ b/pkg/inspect/inspect.go @@ -106,27 +106,27 @@ type LogConfig struct { // ImageData holds the inspect information of an image type ImageData struct { - ID string `json:"Id"` - Digest digest.Digest `json:"Digest"` - RepoTags []string `json:"RepoTags"` - RepoDigests []string `json:"RepoDigests"` - Parent string `json:"Parent"` - Comment string `json:"Comment"` - Created *time.Time `json:"Created"` - ContainerConfig *v1.ImageConfig `json:"ContainerConfig"` - Version string `json:"Version"` - Author string `json:"Author"` - Architecture string `json:"Architecture"` - Os string `json:"Os"` - Size int64 `json:"Size"` - VirtualSize int64 `json:"VirtualSize"` - GraphDriver *Data `json:"GraphDriver"` - RootFS *RootFS `json:"RootFS"` - Labels map[string]string `json:"Labels"` - Annotations map[string]string `json:"Annotations"` - ManifestType string `json:"ManifestType"` - User string `json:"User"` - History []v1.History `json:"History"` + ID string `json:"Id"` + Digest digest.Digest `json:"Digest"` + RepoTags []string `json:"RepoTags"` + RepoDigests []string `json:"RepoDigests"` + Parent string `json:"Parent"` + Comment string `json:"Comment"` + Created *time.Time `json:"Created"` + Config *v1.ImageConfig `json:"Config"` + Version string `json:"Version"` + Author string `json:"Author"` + Architecture string `json:"Architecture"` + Os string `json:"Os"` + Size int64 `json:"Size"` + VirtualSize int64 `json:"VirtualSize"` + GraphDriver *Data `json:"GraphDriver"` + RootFS *RootFS `json:"RootFS"` + Labels map[string]string `json:"Labels"` + Annotations map[string]string `json:"Annotations"` + ManifestType string `json:"ManifestType"` + User string `json:"User"` + History []v1.History `json:"History"` } // RootFS holds the root fs information of an image diff --git a/pkg/varlinkapi/containers_create.go b/pkg/varlinkapi/containers_create.go index bb6273fd1..63bc93686 100644 --- a/pkg/varlinkapi/containers_create.go +++ b/pkg/varlinkapi/containers_create.go @@ -82,7 +82,7 @@ func varlinkCreateToCreateConfig(ctx context.Context, create iopodman.Create, ru // ENTRYPOINT // User input entrypoint takes priority over image entrypoint if len(entrypoint) == 0 { - entrypoint = data.ContainerConfig.Entrypoint + entrypoint = data.Config.Entrypoint } // if entrypoint=, we need to clear the entrypoint if len(entrypoint) == 1 && strings.Join(create.Entrypoint, "") == "" { @@ -96,9 +96,9 @@ func varlinkCreateToCreateConfig(ctx context.Context, create iopodman.Create, ru if len(inputCommand) > 0 { // User command overrides data CMD command = append(command, inputCommand...) - } else if len(data.ContainerConfig.Cmd) > 0 && len(command) == 0 { + } else if len(data.Config.Cmd) > 0 && len(command) == 0 { // If not user command, add CMD - command = append(command, data.ContainerConfig.Cmd...) + command = append(command, data.Config.Cmd...) } if create.Resources.Blkio_weight != 0 { @@ -115,11 +115,11 @@ func varlinkCreateToCreateConfig(ctx context.Context, create iopodman.Create, ru user := create.User if user == "" { - user = data.ContainerConfig.User + user = data.Config.User } // EXPOSED PORTS - portBindings, err := cc.ExposedPorts(create.Exposed_ports, create.Publish, create.Publish_all, data.ContainerConfig.ExposedPorts) + portBindings, err := cc.ExposedPorts(create.Exposed_ports, create.Publish, create.Publish_all, data.Config.ExposedPorts) if err != nil { return nil, err } @@ -143,7 +143,7 @@ func varlinkCreateToCreateConfig(ctx context.Context, create iopodman.Create, ru imageID := data.ID config := &cc.CreateConfig{ Runtime: runtime, - BuiltinImgVolumes: data.ContainerConfig.Volumes, + BuiltinImgVolumes: data.Config.Volumes, ConmonPidFile: create.Conmon_pidfile, ImageVolumeType: create.Image_volume_type, CapAdd: create.Cap_add, -- cgit v1.2.3-54-g00ecf