From 09ae060a7350f8f36dac41d27bb57a63ba52b638 Mon Sep 17 00:00:00 2001 From: Valentin Rothberg Date: Wed, 25 May 2022 12:31:31 +0200 Subject: pkg/api/handlers/compat/images.go: drop TODO message An undefined "this" or "that" is terrible. Signed-off-by: Valentin Rothberg --- pkg/api/handlers/compat/images.go | 2 -- 1 file changed, 2 deletions(-) (limited to 'pkg') diff --git a/pkg/api/handlers/compat/images.go b/pkg/api/handlers/compat/images.go index 8c4dea327..76a28fadf 100644 --- a/pkg/api/handlers/compat/images.go +++ b/pkg/api/handlers/compat/images.go @@ -460,8 +460,6 @@ func GetImages(w http.ResponseWriter, r *http.Request) { } func LoadImages(w http.ResponseWriter, r *http.Request) { - // TODO this is basically wrong - // TODO ... improve these ^ messages to something useful decoder := r.Context().Value(api.DecoderKey).(*schema.Decoder) runtime := r.Context().Value(api.RuntimeKey).(*libpod.Runtime) -- cgit v1.2.3-54-g00ecf From 60e31d87d12206f8af8d0c4fa012033081ad5d31 Mon Sep 17 00:00:00 2001 From: Valentin Rothberg Date: Wed, 25 May 2022 12:33:34 +0200 Subject: pkg/auth: drop the TODO It is not a TODO item and if, it should be added to c/image. Signed-off-by: Valentin Rothberg --- pkg/auth/auth.go | 2 -- 1 file changed, 2 deletions(-) (limited to 'pkg') diff --git a/pkg/auth/auth.go b/pkg/auth/auth.go index 419225007..3a78436d7 100644 --- a/pkg/auth/auth.go +++ b/pkg/auth/auth.go @@ -245,8 +245,6 @@ func authConfigsToAuthFile(authConfigs map[string]types.DockerAuthConfig) (strin } authFilePath := tmpFile.Name() - // TODO: It would be nice if c/image could dump the map at once. - // // Now use the c/image packages to store the credentials. It's battle // tested, and we make sure to use the same code as the image backend. sys := types.SystemContext{AuthFilePath: authFilePath} -- cgit v1.2.3-54-g00ecf From 462cb3370daa0721368ccd91a122a7f9900dfedf Mon Sep 17 00:00:00 2001 From: Valentin Rothberg Date: Wed, 25 May 2022 12:35:01 +0200 Subject: pkg/bindings/containers/archive.go: drop TODO We are already passed 4.0 and a wrapper like this really does not hurt. Signed-off-by: Valentin Rothberg --- pkg/bindings/containers/archive.go | 2 -- 1 file changed, 2 deletions(-) (limited to 'pkg') diff --git a/pkg/bindings/containers/archive.go b/pkg/bindings/containers/archive.go index 4f4b5a36a..dd489d6f1 100644 --- a/pkg/bindings/containers/archive.go +++ b/pkg/bindings/containers/archive.go @@ -55,8 +55,6 @@ func CopyFromArchive(ctx context.Context, nameOrID string, path string, reader i } // CopyFromArchiveWithOptions copy files into container -// -// FIXME: remove this function and make CopyFromArchive accept the option as the last parameter in podman 4.0 func CopyFromArchiveWithOptions(ctx context.Context, nameOrID string, path string, reader io.Reader, options *CopyOptions) (entities.ContainerCopyFunc, error) { conn, err := bindings.GetClient(ctx) if err != nil { -- cgit v1.2.3-54-g00ecf From c9279d4d933dd56653ddf50d5a2482439e8f3648 Mon Sep 17 00:00:00 2001 From: Valentin Rothberg Date: Wed, 25 May 2022 12:36:00 +0200 Subject: pkg/bindings/play/play.go: drop TODO message As already done in a previous commit: a global system context does not make sense for bindings, so remove the message. Signed-off-by: Valentin Rothberg --- pkg/bindings/play/play.go | 1 - 1 file changed, 1 deletion(-) (limited to 'pkg') diff --git a/pkg/bindings/play/play.go b/pkg/bindings/play/play.go index 8058a8514..0261b0250 100644 --- a/pkg/bindings/play/play.go +++ b/pkg/bindings/play/play.go @@ -46,7 +46,6 @@ func KubeWithBody(ctx context.Context, body io.Reader, options *KubeOptions) (*e params.Set("start", strconv.FormatBool(options.GetStart())) } - // TODO: have a global system context we can pass around (1st argument) header, err := auth.MakeXRegistryAuthHeader(&types.SystemContext{AuthFilePath: options.GetAuthfile()}, options.GetUsername(), options.GetPassword()) if err != nil { return nil, err -- cgit v1.2.3-54-g00ecf