From 593d0907c5c11e933be7dbdce98022f76183ea3c Mon Sep 17 00:00:00 2001 From: Daniel J Walsh Date: Thu, 9 Dec 2021 09:52:03 -0500 Subject: --hostname should be set when using --pod new:foobar Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2030599 When you create pod, it shares the UTS namespace with Containers. Currently the --hostname is not passed to the pod created when you create a container and pod in the same command. Also fix error message on supported --share flags Signed-off-by: Daniel J Walsh --- pkg/domain/entities/types.go | 5 +++-- pkg/specgen/generate/namespaces.go | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) (limited to 'pkg') diff --git a/pkg/domain/entities/types.go b/pkg/domain/entities/types.go index ec4d4a902..e062b9442 100644 --- a/pkg/domain/entities/types.go +++ b/pkg/domain/entities/types.go @@ -29,8 +29,6 @@ type PodDeleteReport struct{ Report } type VolumeDeleteOptions struct{} type VolumeDeleteReport struct{ Report } -// NetOptions reflect the shared network options between -// pods and containers type NetFlags struct { AddHosts []string `json:"add-host,omitempty"` DNS []string `json:"dns,omitempty"` @@ -43,6 +41,9 @@ type NetFlags struct { Network string `json:"network,omitempty"` NetworkAlias []string `json:"network-alias,omitempty"` } + +// NetOptions reflect the shared network options between +// pods and containers type NetOptions struct { AddHosts []string `json:"hostadd,omitempty"` Aliases []string `json:"network_alias,omitempty"` diff --git a/pkg/specgen/generate/namespaces.go b/pkg/specgen/generate/namespaces.go index 5349e224f..7d63fc10f 100644 --- a/pkg/specgen/generate/namespaces.go +++ b/pkg/specgen/generate/namespaces.go @@ -474,7 +474,7 @@ func GetNamespaceOptions(ns []string, netnsIsHost bool) ([]libpod.PodCreateOptio case "none": return erroredOptions, nil default: - return erroredOptions, errors.Errorf("Invalid kernel namespace to share: %s. Options are: net, pid, ipc, uts or none", toShare) + return erroredOptions, errors.Errorf("Invalid kernel namespace to share: %s. Options are: cgroup, ipc, net, pid, uts or none", toShare) } } return options, nil -- cgit v1.2.3-54-g00ecf