From 507000a304b34850c358d75af3f6291ed444c8f6 Mon Sep 17 00:00:00 2001 From: Jelle van der Waa Date: Tue, 14 Sep 2021 22:23:01 +0200 Subject: api: handle nil pointer dereference in rest endpoints When `?all=garbage` is passed to an API endpoint schema validation fails and err is nil. Wrapf uses err to create an error message causing a nil pointer dereference. Signed-off-by: Jelle van der Waa --- test/apiv2/10-images.at | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'test/apiv2/10-images.at') diff --git a/test/apiv2/10-images.at b/test/apiv2/10-images.at index abc8d44b7..d3fde9f9d 100644 --- a/test/apiv2/10-images.at +++ b/test/apiv2/10-images.at @@ -94,6 +94,10 @@ t GET libpod/images/json?filters='garb1age}' 500 \ t GET libpod/images/json?filters='{"label":["testl' 500 \ .cause="unexpected end of JSON input" +# Prune images - bad all input +t POST libpod/images/prune?all='garb1age' 500 \ + .cause="schema: error converting value for \"all\"" + # Prune images - bad filter input t POST images/prune?filters='garb1age}' 500 \ .cause="invalid character 'g' looking for beginning of value" -- cgit v1.2.3-54-g00ecf