From 7e30531f20b8c367aad81454abda8505a0d9962a Mon Sep 17 00:00:00 2001 From: Valentin Rothberg Date: Tue, 18 Jan 2022 16:27:33 +0100 Subject: compat attach: fix write on closed channel Waiting on an initialized sync.WaitGroup returns immediately. Hence, move the goroutine to wait and close *after* reading the logs. Fixes: #12904 Signed-off-by: Valentin Rothberg --- test/apiv2/python/rest_api/test_v2_0_0_container.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'test/apiv2/python/rest_api') diff --git a/test/apiv2/python/rest_api/test_v2_0_0_container.py b/test/apiv2/python/rest_api/test_v2_0_0_container.py index 1b4597cf8..0386116a8 100644 --- a/test/apiv2/python/rest_api/test_v2_0_0_container.py +++ b/test/apiv2/python/rest_api/test_v2_0_0_container.py @@ -130,7 +130,7 @@ class ContainerTestCase(APITestCase): def test_attach(self): self.skipTest("FIXME: Test timeouts") - r = requests.post(self.uri(self.resolve_container("/containers/{}/attach")), timeout=5) + r = requests.post(self.uri(self.resolve_container("/containers/{}/attach?logs=true")), timeout=5) self.assertIn(r.status_code, (101, 500), r.text) def test_logs(self): -- cgit v1.2.3-54-g00ecf