From 94e0a364a80470036d87fa75cf53e60dc0c35fe3 Mon Sep 17 00:00:00 2001 From: Ed Santiago Date: Mon, 25 Jul 2022 08:07:43 -0600 Subject: Semiperiodoc cleanup of obsolete FIXMEs Some refer to issues that are closed. Remove them. Some are runc bugs that will never be fixed. Say so, and remove the FIXME. One (bps/iops) should probably be fixed. File an issue for it, and update comment to include the issue# so my find-obsolete-skips script can track it. And one (rootless mount with a "kernel bug?" comment) is still not fixed. Leave the skip, but add a comment documenting the symptom. Signed-off-by: Ed Santiago --- test/e2e/containers_conf_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'test/e2e/containers_conf_test.go') diff --git a/test/e2e/containers_conf_test.go b/test/e2e/containers_conf_test.go index 819efa628..41e78ce0e 100644 --- a/test/e2e/containers_conf_test.go +++ b/test/e2e/containers_conf_test.go @@ -535,7 +535,8 @@ var _ = Describe("Verify podman containers.conf usage", func() { It("podman containers.conf cgroups=disabled", func() { if !strings.Contains(podmanTest.OCIRuntime, "crun") { - Skip("FIXME: requires crun") + // Assume this will never be fixed in runc + Skip("NoCgroups requires crun") } conffile := filepath.Join(podmanTest.TempDir, "container.conf") -- cgit v1.2.3-54-g00ecf