From 65f2f1a7639eb5bc12e6c522c111be18786870c9 Mon Sep 17 00:00:00 2001 From: Ed Santiago Date: Wed, 23 Sep 2020 08:09:31 -0600 Subject: e2e tests: SkipIfRemote(): add a reason Now that Dan has added helpful comments to each SkipIfRemote, let's take the next step and include those messages in the Skip() output so someone viewing test results can easily see if a remote test is skipped for a real reason or for a FIXME. This commit is the result of a simple: perl -pi -e 's;(SkipIfRemote)\(\)(\s+//\s+(.*))?;$1("$3");' *.go in the test/e2e directory, with a few minor (manual) changes in wording. Signed-off-by: Ed Santiago --- test/e2e/manifest_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'test/e2e/manifest_test.go') diff --git a/test/e2e/manifest_test.go b/test/e2e/manifest_test.go index 332e2aa2c..33aac48d5 100644 --- a/test/e2e/manifest_test.go +++ b/test/e2e/manifest_test.go @@ -102,7 +102,7 @@ var _ = Describe("Podman manifest", func() { }) It("podman manifest annotate", func() { - SkipIfRemote() // Not supporting annotate on remote connections + SkipIfRemote("Not supporting annotate on remote connections") session := podmanTest.Podman([]string{"manifest", "create", "foo"}) session.WaitWithDefaultTimeout() Expect(session.ExitCode()).To(Equal(0)) @@ -184,7 +184,7 @@ var _ = Describe("Podman manifest", func() { }) It("podman manifest push purge", func() { - SkipIfRemote() // remote does not support --purge + SkipIfRemote("remote does not support --purge") session := podmanTest.Podman([]string{"manifest", "create", "foo"}) session.WaitWithDefaultTimeout() Expect(session.ExitCode()).To(Equal(0)) -- cgit v1.2.3-54-g00ecf