From be51173ed39c2d16205b0469287b5d6a7271c2c5 Mon Sep 17 00:00:00 2001 From: Ed Santiago Date: Thu, 15 Jul 2021 12:13:15 -0600 Subject: APIv2 (python) tests: fix flake Python tests were flaking because they behave differently when $DEBUG is set. It looks like something in CI sets that envariable. Solution: do not use $DEBUG as a debug trigger, use a properly-named custom variable that is unlikely to be set accidentally. Also: get rid of AssertTrue(), which gives no visibility into what happened. Write in proper form that can emit useful diagnostics on failure. Fixes: #10948 Signed-off-by: Ed Santiago --- test/python/docker/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'test/python/docker/__init__.py') diff --git a/test/python/docker/__init__.py b/test/python/docker/__init__.py index 59b7987f4..f75185192 100644 --- a/test/python/docker/__init__.py +++ b/test/python/docker/__init__.py @@ -27,7 +27,7 @@ class Podman(object): # No support for tmpfs (/tmp) or extfs (/var/tmp) # self.cmd.append("--storage-driver=overlay") - if os.getenv("DEBUG"): + if os.getenv("PODMAN_PYTHON_TEST_DEBUG"): self.cmd.append("--log-level=debug") self.cmd.append("--syslog=true") -- cgit v1.2.3-54-g00ecf