From db23e1261165bae3dda38bc1f3b6a11573e36417 Mon Sep 17 00:00:00 2001 From: Daniel J Walsh Date: Wed, 7 Oct 2020 15:27:54 -0400 Subject: Add support for external container External containers are containers created outside of Podman. For example Buildah and CRI-O Containers. $ buildah from alpine alpine-working-container $ buildah run alpine-working-container touch /test $ podman container exists --external alpine-working-container $ podman container diff alpine-working-container C /etc A /test Added --external flag to refer to external containers, rather then --storage. Added --external for podman container exists and modified podman ps to use --external rather then --storage. It was felt that --storage would confuse the user into thinking about changing the storage driver or options. --storage is still supported through the use of aliases. Finally podman contianer diff, does not require the --external flag, since it there is little change of users making the mistake, and would just be a pain for the user to remember the flag. podman container exists --external is required because it could fool scripts that rely on the existance of a Podman container, and there is a potential for a partial deletion of a container, which could mess up existing users. Signed-off-by: Daniel J Walsh --- test/system/030-run.bats | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'test/system') diff --git a/test/system/030-run.bats b/test/system/030-run.bats index a82743c70..f7c48da8d 100644 --- a/test/system/030-run.bats +++ b/test/system/030-run.bats @@ -471,8 +471,11 @@ json-file | f run buildah from $IMAGE cid="$output" + # exists should fail + run_podman 1 container exists $cid + # exists should succeed - run_podman container exists $cid + run_podman container exists --external $cid run buildah rm $cid } -- cgit v1.2.3-54-g00ecf