From 2fa906ccae477decfd0f124cdc10c0367d3856d6 Mon Sep 17 00:00:00 2001 From: Valentin Rothberg Date: Thu, 5 May 2022 10:14:36 +0200 Subject: e2e: pull_test: remove redundant tests Once upon a time, the tests actually pulled from Docker Hub. This has changed with the rate limits, so we can safely remove the redundant tests to speed up CI. Signed-off-by: Valentin Rothberg --- test/e2e/pull_test.go | 34 ++++------------------------------ 1 file changed, 4 insertions(+), 30 deletions(-) (limited to 'test') diff --git a/test/e2e/pull_test.go b/test/e2e/pull_test.go index 41eb8b449..80fb5c2ba 100644 --- a/test/e2e/pull_test.go +++ b/test/e2e/pull_test.go @@ -53,13 +53,13 @@ var _ = Describe("Podman pull", func() { Expect(session).Should(Exit(0)) }) - It("podman pull from docker a not existing image", func() { - session := podmanTest.Podman([]string{"pull", "ibetthisdoesntexistthere:foo"}) + It("podman pull bogus image", func() { + session := podmanTest.Podman([]string{"pull", "quay.io/ibetthis/doesntexistthere:foo"}) session.WaitWithDefaultTimeout() Expect(session).To(ExitWithError()) }) - It("podman pull from docker with tag", func() { + It("podman pull with tag", func() { session := podmanTest.Podman([]string{"pull", "quay.io/libpod/testdigest_v2s2:20200210"}) session.WaitWithDefaultTimeout() Expect(session).Should(Exit(0)) @@ -69,7 +69,7 @@ var _ = Describe("Podman pull", func() { Expect(session).Should(Exit(0)) }) - It("podman pull from docker without tag", func() { + It("podman pull without tag", func() { session := podmanTest.Podman([]string{"pull", "quay.io/libpod/testdigest_v2s2"}) session.WaitWithDefaultTimeout() Expect(session).Should(Exit(0)) @@ -79,26 +79,6 @@ var _ = Describe("Podman pull", func() { Expect(session).Should(Exit(0)) }) - It("podman pull from alternate registry with tag", func() { - session := podmanTest.Podman([]string{"pull", cirros}) - session.WaitWithDefaultTimeout() - Expect(session).Should(Exit(0)) - - session = podmanTest.Podman([]string{"rmi", cirros}) - session.WaitWithDefaultTimeout() - Expect(session).Should(Exit(0)) - }) - - It("podman pull from alternate registry without tag", func() { - session := podmanTest.Podman([]string{"pull", "quay.io/libpod/cirros"}) - session.WaitWithDefaultTimeout() - Expect(session).Should(Exit(0)) - - session = podmanTest.Podman([]string{"rmi", "quay.io/libpod/cirros"}) - session.WaitWithDefaultTimeout() - Expect(session).Should(Exit(0)) - }) - It("podman pull by digest", func() { session := podmanTest.Podman([]string{"pull", "quay.io/libpod/testdigest_v2s2@sha256:755f4d90b3716e2bf57060d249e2cd61c9ac089b1233465c5c2cb2d7ee550fdb"}) session.WaitWithDefaultTimeout() @@ -251,12 +231,6 @@ var _ = Describe("Podman pull", func() { Expect(session).Should(Exit(0)) }) - It("podman pull bogus image", func() { - session := podmanTest.Podman([]string{"pull", "umohnani/get-started"}) - session.WaitWithDefaultTimeout() - Expect(session).To(ExitWithError()) - }) - It("podman pull from docker-archive", func() { SkipIfRemote("podman-remote does not support pulling from docker-archive") -- cgit v1.2.3-54-g00ecf