1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
|
package specgen
import (
"net"
"testing"
"github.com/containers/podman/v3/libpod/network/types"
"github.com/containers/podman/v3/pkg/rootless"
"github.com/stretchr/testify/assert"
)
func parsMacNoErr(mac string) types.HardwareAddr {
m, _ := net.ParseMAC(mac)
return types.HardwareAddr(m)
}
func TestParseNetworkFlag(t *testing.T) {
// root and rootless have different defaults
defaultNetName := "default"
defaultNetworks := map[string]types.PerNetworkOptions{
defaultNetName: {},
}
defaultNsMode := Namespace{NSMode: Bridge}
if rootless.IsRootless() {
defaultNsMode = Namespace{NSMode: Slirp}
defaultNetworks = map[string]types.PerNetworkOptions{}
}
tests := []struct {
name string
args []string
nsmode Namespace
networks map[string]types.PerNetworkOptions
options map[string][]string
err string
}{
{
name: "empty input",
args: nil,
nsmode: defaultNsMode,
networks: defaultNetworks,
},
{
name: "empty string as input",
args: []string{},
nsmode: defaultNsMode,
networks: defaultNetworks,
},
{
name: "default mode",
args: []string{"default"},
nsmode: defaultNsMode,
networks: defaultNetworks,
},
{
name: "private mode",
args: []string{"private"},
nsmode: defaultNsMode,
networks: defaultNetworks,
},
{
name: "bridge mode",
args: []string{"bridge"},
nsmode: Namespace{NSMode: Bridge},
networks: map[string]types.PerNetworkOptions{
defaultNetName: {},
},
},
{
name: "slirp4netns mode",
args: []string{"slirp4netns"},
nsmode: Namespace{NSMode: Slirp},
networks: map[string]types.PerNetworkOptions{},
},
{
name: "from pod mode",
args: []string{"pod"},
nsmode: Namespace{NSMode: FromPod},
networks: map[string]types.PerNetworkOptions{},
},
{
name: "no network mode",
args: []string{"none"},
nsmode: Namespace{NSMode: NoNetwork},
networks: map[string]types.PerNetworkOptions{},
},
{
name: "container mode",
args: []string{"container:abc"},
nsmode: Namespace{NSMode: FromContainer, Value: "abc"},
networks: map[string]types.PerNetworkOptions{},
},
{
name: "ns path mode",
args: []string{"ns:/path"},
nsmode: Namespace{NSMode: Path, Value: "/path"},
networks: map[string]types.PerNetworkOptions{},
},
{
name: "slirp4netns mode with options",
args: []string{"slirp4netns:cidr=10.0.0.0/24"},
nsmode: Namespace{NSMode: Slirp},
networks: map[string]types.PerNetworkOptions{},
options: map[string][]string{
"slirp4netns": {"cidr=10.0.0.0/24"},
},
},
{
name: "bridge mode with options 1",
args: []string{"bridge:ip=10.0.0.1,mac=11:22:33:44:55:66"},
nsmode: Namespace{NSMode: Bridge},
networks: map[string]types.PerNetworkOptions{
defaultNetName: {
StaticIPs: []net.IP{net.ParseIP("10.0.0.1")},
StaticMAC: parsMacNoErr("11:22:33:44:55:66"),
},
},
},
{
name: "bridge mode with options 2",
args: []string{"bridge:ip=10.0.0.1,ip=10.0.0.5"},
nsmode: Namespace{NSMode: Bridge},
networks: map[string]types.PerNetworkOptions{
defaultNetName: {
StaticIPs: []net.IP{net.ParseIP("10.0.0.1"), net.ParseIP("10.0.0.5")},
},
},
},
{
name: "bridge mode with ip6 option",
args: []string{"bridge:ip6=fd10::"},
nsmode: Namespace{NSMode: Bridge},
networks: map[string]types.PerNetworkOptions{
defaultNetName: {
StaticIPs: []net.IP{net.ParseIP("fd10::")},
},
},
},
{
name: "bridge mode with alias option",
args: []string{"bridge:alias=myname,alias=myname2"},
nsmode: Namespace{NSMode: Bridge},
networks: map[string]types.PerNetworkOptions{
defaultNetName: {
Aliases: []string{"myname", "myname2"},
},
},
},
{
name: "bridge mode with alias option",
args: []string{"bridge:alias=myname,alias=myname2"},
nsmode: Namespace{NSMode: Bridge},
networks: map[string]types.PerNetworkOptions{
defaultNetName: {
Aliases: []string{"myname", "myname2"},
},
},
},
{
name: "bridge mode with interface option",
args: []string{"bridge:interface_name=eth123"},
nsmode: Namespace{NSMode: Bridge},
networks: map[string]types.PerNetworkOptions{
defaultNetName: {
InterfaceName: "eth123",
},
},
},
{
name: "bridge mode with invalid option",
args: []string{"bridge:abc=123"},
nsmode: Namespace{NSMode: Bridge},
err: "unknown bridge network option: abc",
},
{
name: "bridge mode with invalid ip",
args: []string{"bridge:ip=10..1"},
nsmode: Namespace{NSMode: Bridge},
err: "invalid ip address \"10..1\"",
},
{
name: "bridge mode with invalid mac",
args: []string{"bridge:mac=123"},
nsmode: Namespace{NSMode: Bridge},
err: "address 123: invalid MAC address",
},
{
name: "network name",
args: []string{"someName"},
nsmode: Namespace{NSMode: Bridge},
networks: map[string]types.PerNetworkOptions{
"someName": {},
},
},
{
name: "network name with options",
args: []string{"someName:ip=10.0.0.1"},
nsmode: Namespace{NSMode: Bridge},
networks: map[string]types.PerNetworkOptions{
"someName": {StaticIPs: []net.IP{net.ParseIP("10.0.0.1")}},
},
},
{
name: "multiple networks",
args: []string{"someName", "net2"},
nsmode: Namespace{NSMode: Bridge},
networks: map[string]types.PerNetworkOptions{
"someName": {},
"net2": {},
},
},
{
name: "multiple networks with options",
args: []string{"someName:ip=10.0.0.1", "net2:ip=10.10.0.1"},
nsmode: Namespace{NSMode: Bridge},
networks: map[string]types.PerNetworkOptions{
"someName": {StaticIPs: []net.IP{net.ParseIP("10.0.0.1")}},
"net2": {StaticIPs: []net.IP{net.ParseIP("10.10.0.1")}},
},
},
{
name: "multiple networks with bridge mode first should map to default net",
args: []string{"bridge", "net2"},
nsmode: Namespace{NSMode: Bridge},
networks: map[string]types.PerNetworkOptions{
defaultNetName: {},
"net2": {},
},
},
{
name: "conflicting network modes should error",
args: []string{"bridge", "host"},
nsmode: Namespace{NSMode: Bridge},
err: "can only set extra network names, selected mode host conflicts with bridge: invalid argument",
},
{
name: "multiple networks empty name should error",
args: []string{"someName", ""},
nsmode: Namespace{NSMode: Bridge},
err: "network name cannot be empty: invalid argument",
},
{
name: "multiple networks on invalid mode should error",
args: []string{"host", "net2"},
nsmode: Namespace{NSMode: Host},
err: "cannot set multiple networks without bridge network mode, selected mode host: invalid argument",
},
}
for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
got, got1, got2, err := ParseNetworkFlag(tt.args)
if tt.err != "" {
assert.EqualError(t, err, tt.err, tt.name)
} else {
assert.NoError(t, err, tt.name)
}
assert.Equal(t, tt.nsmode, got, tt.name)
assert.Equal(t, tt.networks, got1, tt.name)
assert.Equal(t, tt.options, got2, tt.name)
})
}
}
|
