summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorValentin Rothberg <rothberg@redhat.com>2020-04-29 14:42:30 +0200
committerValentin Rothberg <rothberg@redhat.com>2020-04-29 15:23:30 +0200
commit5c108f75ebdf4bf9214504f8b170ffabff1a38d4 (patch)
tree6d0fa3e364fbc87e3e096265401084b1574ba4b5
parent417764187513561e0fb66c30b23c20cb199a747a (diff)
downloadpodman-5c108f75ebdf4bf9214504f8b170ffabff1a38d4.tar.gz
podman-5c108f75ebdf4bf9214504f8b170ffabff1a38d4.tar.bz2
podman-5c108f75ebdf4bf9214504f8b170ffabff1a38d4.zip
login system test: enable "push ok"
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
-rw-r--r--pkg/bindings/images/images.go5
-rw-r--r--test/system/150-login.bats2
2 files changed, 3 insertions, 4 deletions
diff --git a/pkg/bindings/images/images.go b/pkg/bindings/images/images.go
index ff49ca914..63fe2556b 100644
--- a/pkg/bindings/images/images.go
+++ b/pkg/bindings/images/images.go
@@ -311,8 +311,9 @@ func Push(ctx context.Context, source string, destination string, options entiti
params.Set("credentials", options.Credentials)
params.Set("destination", destination)
if options.SkipTLSVerify != types.OptionalBoolUndefined {
- val := bool(options.SkipTLSVerify == types.OptionalBoolTrue)
- params.Set("tlsVerify", strconv.FormatBool(!val))
+ // Note: we have to verify if skipped is false.
+ verifyTLS := bool(options.SkipTLSVerify == types.OptionalBoolFalse)
+ params.Set("tlsVerify", strconv.FormatBool(verifyTLS))
}
path := fmt.Sprintf("/images/%s/push", source)
diff --git a/test/system/150-login.bats b/test/system/150-login.bats
index 3edb11c2f..a6f9aab85 100644
--- a/test/system/150-login.bats
+++ b/test/system/150-login.bats
@@ -166,8 +166,6 @@ function setup() {
# Some push tests
@test "podman push fail" {
- skip "Not working for v2 yet"
-
# Create an invalid authfile
authfile=${PODMAN_LOGIN_WORKDIR}/auth-$(random_string 10).json
rm -f $authfile