aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorValentin Rothberg <rothberg@redhat.com>2021-02-15 15:07:25 +0100
committerValentin Rothberg <rothberg@redhat.com>2021-02-15 15:07:25 +0100
commit0ab5bfd3133136595abcb3d1b8b6a91719acd8af (patch)
treea7b3fe88bedd4ee5b43498ec49befab661ca4170
parent704fa8b55e2f4f9b062372f38ce881456b18c5c6 (diff)
downloadpodman-0ab5bfd3133136595abcb3d1b8b6a91719acd8af.tar.gz
podman-0ab5bfd3133136595abcb3d1b8b6a91719acd8af.tar.bz2
podman-0ab5bfd3133136595abcb3d1b8b6a91719acd8af.zip
e2e: fix network alias test
The logic in the e2e test for multiple network aliases is indicating the test should wait for the containerized nginx to be ready. As this may take some time, the test does an exponential backoff starting at 2050ms. Fix the logic by removing the `Expect(...)` call during the exponential backoff. Otherwise, the test errors immediately. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
-rw-r--r--test/e2e/network_test.go3
1 files changed, 2 insertions, 1 deletions
diff --git a/test/e2e/network_test.go b/test/e2e/network_test.go
index d4e1a3698..40731f8c5 100644
--- a/test/e2e/network_test.go
+++ b/test/e2e/network_test.go
@@ -407,6 +407,7 @@ var _ = Describe("Podman network", func() {
Expect(lines[0]).To(Equal(netName1))
Expect(lines[1]).To(Equal(netName2))
})
+
It("podman network with multiple aliases", func() {
var worked bool
netName := "aliasTest" + stringid.GenerateNonCryptoID()
@@ -424,7 +425,7 @@ var _ = Describe("Podman network", func() {
// Test curl against the container's name
c1 := podmanTest.Podman([]string{"run", "--network=" + netName, nginx, "curl", "web"})
c1.WaitWithDefaultTimeout()
- worked = Expect(c1.ExitCode()).To(BeZero())
+ worked = c1.ExitCode() == 0
if worked {
break
}