aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrent Baude <bbaude@redhat.com>2020-03-12 12:43:32 -0500
committerBrent Baude <bbaude@redhat.com>2020-03-12 12:43:32 -0500
commit3aa58ccd0a622d539b24df2d8fd68fe0b0d6d208 (patch)
treed9afa9fbda038a8cea16522ae50737450703c451
parent9c7481dbd1e6ea7e20ee03c85d4710c42ba81c6e (diff)
downloadpodman-3aa58ccd0a622d539b24df2d8fd68fe0b0d6d208.tar.gz
podman-3aa58ccd0a622d539b24df2d8fd68fe0b0d6d208.tar.bz2
podman-3aa58ccd0a622d539b24df2d8fd68fe0b0d6d208.zip
remove imagefilter for varlink remote client
the api for getting images changed to use filters but back level podman versions cannot handle it. so temporarily disabling the filtering for remote clients until the restful approach can be used. Signed-off-by: Brent Baude <bbaude@redhat.com>
-rw-r--r--cmd/podman/images.go2
-rw-r--r--pkg/adapter/runtime_remote.go5
2 files changed, 5 insertions, 2 deletions
diff --git a/cmd/podman/images.go b/cmd/podman/images.go
index de61690ae..41790a5aa 100644
--- a/cmd/podman/images.go
+++ b/cmd/podman/images.go
@@ -155,7 +155,7 @@ func imagesCmd(c *cliconfig.ImagesValues) error {
return errors.New("can not specify an image and a filter")
}
filters := c.Filter
- if len(filters) < 1 {
+ if len(filters) < 1 && len(image) > 0 {
filters = append(filters, fmt.Sprintf("reference=%s", image))
}
diff --git a/pkg/adapter/runtime_remote.go b/pkg/adapter/runtime_remote.go
index 220d4cf75..d87de481c 100644
--- a/pkg/adapter/runtime_remote.go
+++ b/pkg/adapter/runtime_remote.go
@@ -201,8 +201,11 @@ func (r *LocalRuntime) GetRWImages() ([]*ContainerImage, error) {
}
func (r *LocalRuntime) GetFilteredImages(filters []string, rwOnly bool) ([]*ContainerImage, error) {
+ if len(filters) > 0 {
+ return nil, errors.Wrap(define.ErrNotImplemented, "filtering images is not supported on the remote client")
+ }
var newImages []*ContainerImage
- images, err := iopodman.ListImagesWithFilters().Call(r.Conn, filters)
+ images, err := iopodman.ListImages().Call(r.Conn)
if err != nil {
return nil, err
}