diff options
| author | Brent Baude <bbaude@redhat.com> | 2020-08-04 13:41:44 -0500 |
|---|---|---|
| committer | Valentin Rothberg <rothberg@redhat.com> | 2020-08-11 13:53:23 +0200 |
| commit | 43527de53e40b737333502f6fbb2e1d73a3f3ec9 (patch) | |
| tree | 30a910037de1b19267542edc1983b801d971eb52 | |
| parent | 9b591e11d5d65e210871fa5a8d5083f6f6844434 (diff) | |
| download | podman-43527de53e40b737333502f6fbb2e1d73a3f3ec9.tar.gz podman-43527de53e40b737333502f6fbb2e1d73a3f3ec9.tar.bz2 podman-43527de53e40b737333502f6fbb2e1d73a3f3ec9.zip | |
correct go-binding key for volumes
the go binding for remove container was using 'vols' for a key to remove volumes associated to the container. the correct key should be "v" and is documented as such.
Fixes: #7128
Signed-off-by: Brent Baude <bbaude@redhat.com>
| -rw-r--r-- | pkg/bindings/containers/containers.go | 2 | ||||
| -rw-r--r-- | test/system/160-volumes.bats | 2 |
2 files changed, 1 insertions, 3 deletions
diff --git a/pkg/bindings/containers/containers.go b/pkg/bindings/containers/containers.go index c690ea125..c479e5dcb 100644 --- a/pkg/bindings/containers/containers.go +++ b/pkg/bindings/containers/containers.go @@ -98,7 +98,7 @@ func Remove(ctx context.Context, nameOrID string, force, volumes *bool) error { params.Set("force", strconv.FormatBool(*force)) } if volumes != nil { - params.Set("vols", strconv.FormatBool(*volumes)) + params.Set("v", strconv.FormatBool(*volumes)) } response, err := conn.DoRequest(nil, http.MethodDelete, "/containers/%s", params, nil, nameOrID) if err != nil { diff --git a/test/system/160-volumes.bats b/test/system/160-volumes.bats index ef38b2a68..e2aefed43 100644 --- a/test/system/160-volumes.bats +++ b/test/system/160-volumes.bats @@ -142,8 +142,6 @@ EOF # Anonymous temporary volumes, and persistent autocreated named ones @test "podman volume, implicit creation with run" { - skip_if_remote "FIXME: pending #7128" - # No hostdir arg: create anonymous container with random name rand=$(random_string) run_podman run -v /myvol $IMAGE sh -c "echo $rand >/myvol/myfile" |