diff options
| author | Ed Santiago <santiago@redhat.com> | 2022-09-28 09:30:23 -0600 |
|---|---|---|
| committer | Ed Santiago <santiago@redhat.com> | 2022-09-28 09:30:23 -0600 |
| commit | 496d4c7533be0bd786508da50fc4468bef5b69be (patch) | |
| tree | 7d15e51a0a1371e4ead2907fb57f0bbe9ab7334a | |
| parent | dca5ead2d7ad8ac3b14fed6736c102b571d8baf1 (diff) | |
| download | podman-496d4c7533be0bd786508da50fc4468bef5b69be.tar.gz podman-496d4c7533be0bd786508da50fc4468bef5b69be.tar.bz2 podman-496d4c7533be0bd786508da50fc4468bef5b69be.zip | |
System tests: stop deep-checking log-level
I was testing --log-level by --storage-opt=mount_program=/bin/false
Stop doing that. It's just constantly breaking everything (#15698
and #15977).
I am violently of the opinion that a command-line option must
not destroy a user's system (except for --set-something, --config,
something that makes it very very clear that it is a lasting
change). I seem to be in the minority on this opinion. So, I
give up.
Signed-off-by: Ed Santiago <santiago@redhat.com>
| -rw-r--r-- | test/system/001-basic.bats | 35 |
1 files changed, 0 insertions, 35 deletions
diff --git a/test/system/001-basic.bats b/test/system/001-basic.bats index ba6bde4df..f6b4aa1e8 100644 --- a/test/system/001-basic.bats +++ b/test/system/001-basic.bats @@ -215,47 +215,12 @@ See 'podman version --help'" "podman version --remote" run_podman --log-level=warn info assert "$output" !~ " level=" "log-level=warn shows no logs at all" - # Force a warning (local podman only; podman-remote doesn't check versions) - if ! is_remote; then - run_podman --log-level=warn --storage-opt=mount_program=/bin/false info - assert "$output" =~ " level=warning msg=\"Failed to retrieve " \ - "log-level=warn" - - # confirm that default level is "warn", by invoking without --log-level - run_podman --storage-opt=mount_program=/bin/false info - assert "$output" =~ " level=warning msg=\"Failed to retrieve " \ - "default log level includes warning messages" - fi - run_podman --log-level=warning info assert "$output" !~ " level=" "log-level=warning shows no logs at all" run_podman --log-level=error info assert "$output" !~ " level=" "log-level=error shows no logs at all" - # error, fatal, panic: - if is_remote; then - # podman-remote does not grok --runtime; all we can do is test parsing - for level in error fatal panic; do - run_podman --log-level=$level info - assert "$output" !~ " level=" \ - "log-level=$level shows no logs at all" - done - else - # local podman only - run_podman --log-level=error --storage-opt=mount_program=/bin/false --runtime=/bin/false info - assert "$output" =~ " level=error msg=\"Getting info on OCI runtime " \ - "log-level=error shows " - assert "$output" !~ " level=warn" \ - "log-level=error does not show warnings" - - run_podman --log-level=fatal --storage-opt=mount_program=/bin/false --runtime=/bin/false info - assert "$output" !~ " level=" "log-level=fatal shows no logs at all" - - run_podman --log-level=panic --storage-opt=mount_program=/bin/false --runtime=/bin/false info - assert "$output" !~ " level=" "log-level=panic shows no logs at all" - fi - # docker compat run_podman --debug info assert "$output" =~ " level=debug " "podman --debug gives debug output" |