aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGiuseppe Scrivano <gscrivan@redhat.com>2018-10-11 15:17:18 +0200
committerGiuseppe Scrivano <gscrivan@redhat.com>2018-10-11 17:49:16 +0200
commit55c9b03bafebac0c388966f6c1834108de42f4a6 (patch)
tree05a9f21168f2fe0a0aab59e9c9991a544ead8b5f
parent2933c3b98061534f27626bf99be9d6afc65b37f8 (diff)
downloadpodman-55c9b03bafebac0c388966f6c1834108de42f4a6.tar.gz
podman-55c9b03bafebac0c388966f6c1834108de42f4a6.tar.bz2
podman-55c9b03bafebac0c388966f6c1834108de42f4a6.zip
rootless: detect when user namespaces are not enabled
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
-rw-r--r--pkg/rootless/rootless_linux.c29
1 files changed, 28 insertions, 1 deletions
diff --git a/pkg/rootless/rootless_linux.c b/pkg/rootless/rootless_linux.c
index 11c3c32f0..9eb16c1a5 100644
--- a/pkg/rootless/rootless_linux.c
+++ b/pkg/rootless/rootless_linux.c
@@ -13,6 +13,9 @@
#include <sys/wait.h>
#include <string.h>
+static const char *_max_user_namespaces = "/proc/sys/user/max_user_namespaces";
+static const char *_unprivileged_user_namespaces = "/proc/sys/kernel/unprivileged_userns_clone";
+
static int
syscall_setresuid (uid_t ruid, uid_t euid, uid_t suid)
{
@@ -145,6 +148,25 @@ reexec_userns_join (int userns)
_exit (EXIT_FAILURE);
}
+static void
+check_proc_sys_userns_file (const char *path)
+{
+ FILE *fp;
+ fp = fopen (path, "r");
+ if (fp)
+ {
+ char buf[32];
+ size_t n_read = fread (buf, 1, sizeof(buf) - 1, fp);
+ if (n_read > 0)
+ {
+ buf[n_read] = '\0';
+ if (strtol (buf, NULL, 10) == 0)
+ fprintf (stderr, "user namespaces are not enabled in %s\n", path);
+ }
+ fclose (fp);
+ }
+}
+
int
reexec_in_user_namespace (int ready)
{
@@ -159,7 +181,12 @@ reexec_in_user_namespace (int ready)
pid = syscall_clone (CLONE_NEWUSER|CLONE_NEWNS|SIGCHLD, NULL);
if (pid < 0)
- fprintf (stderr, "cannot clone: %s\n", strerror (errno));
+ {
+ FILE *fp;
+ fprintf (stderr, "cannot clone: %s\n", strerror (errno));
+ check_proc_sys_userns_file (_max_user_namespaces);
+ check_proc_sys_userns_file (_unprivileged_user_namespaces);
+ }
if (pid)
return pid;