diff options
| author | Ashley Cui <acui@redhat.com> | 2022-06-03 14:08:59 -0400 |
|---|---|---|
| committer | Ashley Cui <acui@redhat.com> | 2022-06-03 14:13:18 -0400 |
| commit | 9de092ec001ed64ab9f1f40e24ee204e46cf73eb (patch) | |
| tree | 375717b0548d0cb7ad9ec1981c216ba6167da661 | |
| parent | 0dda4681927b3428a113c81d851d962da8dd7302 (diff) | |
| download | podman-9de092ec001ed64ab9f1f40e24ee204e46cf73eb.tar.gz podman-9de092ec001ed64ab9f1f40e24ee204e46cf73eb.tar.bz2 podman-9de092ec001ed64ab9f1f40e24ee204e46cf73eb.zip | |
Fix secret-verify-leak flake: set build context to subdir
Setting the build context to a dedicated subdir makes sure that the test does not
flake when running in parallel, as the test is isolated from other tests
that may dump secrets in a higher level context dir.
This should have been done in
https://github.com/containers/podman/pull/13457, as this makes that PR
actually work.
Signed-off-by: Ashley Cui <acui@redhat.com>
| -rw-r--r-- | test/e2e/build_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/e2e/build_test.go b/test/e2e/build_test.go index 86dc76116..0b766dcc8 100644 --- a/test/e2e/build_test.go +++ b/test/e2e/build_test.go @@ -85,7 +85,7 @@ var _ = Describe("Podman build", func() { }) It("podman build with a secret from file and verify if secret file is not leaked into image", func() { - session := podmanTest.Podman([]string{"build", "-f", "build/secret-verify-leak/Containerfile.with-secret-verify-leak", "-t", "secret-test-leak", "--secret", "id=mysecret,src=build/secret.txt", "build/"}) + session := podmanTest.Podman([]string{"build", "-f", "build/secret-verify-leak/Containerfile.with-secret-verify-leak", "-t", "secret-test-leak", "--secret", "id=mysecret,src=build/secret.txt", "build/secret-verify-leak"}) session.WaitWithDefaultTimeout() Expect(session).Should(Exit(0)) Expect(session.OutputToString()).To(ContainSubstring("somesecret")) |