diff options
| author | Urvashi Mohnani <umohnani@redhat.com> | 2021-11-09 10:01:51 -0500 |
|---|---|---|
| committer | Urvashi Mohnani <umohnani@redhat.com> | 2021-11-10 14:48:08 -0500 |
| commit | a55fdbb49c94038a8e9b88dd876b175e32292697 (patch) | |
| tree | 96da6bffe083aa8c22e9d549c36b08b3bebb7f12 | |
| parent | 4bf0146c2978960b8c4dc5a9844c4948effbcfd2 (diff) | |
| download | podman-a55fdbb49c94038a8e9b88dd876b175e32292697.tar.gz podman-a55fdbb49c94038a8e9b88dd876b175e32292697.tar.bz2 podman-a55fdbb49c94038a8e9b88dd876b175e32292697.zip | |
Print headers for system connection ls
Print out the headers even if the system connection list
is empty to match the behavior of other list commands.
Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
| -rw-r--r-- | cmd/podman/system/connection/list.go | 4 | ||||
| -rw-r--r-- | test/e2e/system_connection_test.go | 2 | ||||
| -rw-r--r-- | test/system/272-system-connection.bats | 3 |
3 files changed, 3 insertions, 6 deletions
diff --git a/cmd/podman/system/connection/list.go b/cmd/podman/system/connection/list.go index a3290e3d6..f1f7657ad 100644 --- a/cmd/podman/system/connection/list.go +++ b/cmd/podman/system/connection/list.go @@ -53,10 +53,6 @@ func list(cmd *cobra.Command, _ []string) error { return err } - if len(cfg.Engine.ServiceDestinations) == 0 { - return nil - } - hdrs := []map[string]string{{ "Identity": "Identity", "Name": "Name", diff --git a/test/e2e/system_connection_test.go b/test/e2e/system_connection_test.go index c0e29d525..76b442ce8 100644 --- a/test/e2e/system_connection_test.go +++ b/test/e2e/system_connection_test.go @@ -236,7 +236,7 @@ var _ = Describe("podman system connection", func() { session := podmanTest.Podman(cmd) session.WaitWithDefaultTimeout() Expect(session).Should(Exit(0)) - Expect(session.Out.Contents()).Should(BeEmpty()) + Expect(len(session.OutputToStringArray())).Should(Equal(1)) Expect(session.Err.Contents()).Should(BeEmpty()) }) }) diff --git a/test/system/272-system-connection.bats b/test/system/272-system-connection.bats index 14c4f6664..4e9ac4dd6 100644 --- a/test/system/272-system-connection.bats +++ b/test/system/272-system-connection.bats @@ -50,7 +50,8 @@ function _run_podman_remote() { # Very basic test, does not actually connect at any time @test "podman system connection - basic add / ls / remove" { run_podman system connection ls - is "$output" "" "system connection ls: no connections" + is "$output" "Name URI Identity Default" \ + "system connection ls: no connections" c1="c1_$(random_string 15)" c2="c2_$(random_string 15)" |