diff options
| author | OpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com> | 2020-01-30 17:10:20 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-01-30 17:10:20 -0800 |
| commit | ba1d1304a67bb1a67482998763f3663fa43edd79 (patch) | |
| tree | ce272d32d985ac9686798f55e282e8316268ae40 | |
| parent | 4f96b17ef58f83e58af2a8016e1acc7f68a959c7 (diff) | |
| parent | 9bbf08de254dbaad9f12b6ad8a72650994c04fd2 (diff) | |
| download | podman-ba1d1304a67bb1a67482998763f3663fa43edd79.tar.gz podman-ba1d1304a67bb1a67482998763f3663fa43edd79.tar.bz2 podman-ba1d1304a67bb1a67482998763f3663fa43edd79.zip | |
Merge pull request #5028 from baude/commitimage
make image reference for commit optional
| -rw-r--r-- | cmd/podman/commit.go | 9 | ||||
| -rw-r--r-- | docs/source/markdown/podman-commit.1.md | 2 |
2 files changed, 7 insertions, 4 deletions
diff --git a/cmd/podman/commit.go b/cmd/podman/commit.go index e98b71514..604e8d31c 100644 --- a/cmd/podman/commit.go +++ b/cmd/podman/commit.go @@ -56,12 +56,15 @@ func commitCmd(c *cliconfig.CommitValues) error { defer runtime.DeferredShutdown(false) args := c.InputArgs - if len(args) != 2 { - return errors.Errorf("you must provide a container name or ID and a target image name") + if len(args) < 1 { + return errors.Errorf("you must provide a container name or ID and optionally a target image name") } container := args[0] - reference := args[1] + reference := "" + if len(args) > 1 { + reference = args[1] + } if c.Flag("change").Changed { for _, change := range c.Change { splitChange := strings.Split(strings.ToUpper(change), "=") diff --git a/docs/source/markdown/podman-commit.1.md b/docs/source/markdown/podman-commit.1.md index 07a885ae2..042ec7934 100644 --- a/docs/source/markdown/podman-commit.1.md +++ b/docs/source/markdown/podman-commit.1.md @@ -6,7 +6,7 @@ podman\-commit - Create new image based on the changed container ## SYNOPSIS **podman commit** [*options*] *container* *image* -**podman container commit** [*options*] *container* *image* +**podman container commit** [*options*] *container* [*image*] ## DESCRIPTION **podman commit** creates an image based on a changed container. The author of the |