aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel J Walsh <dwalsh@redhat.com>2020-11-11 07:57:04 -0500
committerDaniel J Walsh <dwalsh@redhat.com>2020-11-11 13:11:15 -0500
commitf3648b4ae84ea843fb3319a2c6dc20f3a4adff35 (patch)
tree0f41d632e2809ed1e0fef0244de152514b0540fb
parentea753128952e1a6d4b56cc80d232f6dbfb420ba5 (diff)
downloadpodman-f3648b4ae84ea843fb3319a2c6dc20f3a4adff35.tar.gz
podman-f3648b4ae84ea843fb3319a2c6dc20f3a4adff35.tar.bz2
podman-f3648b4ae84ea843fb3319a2c6dc20f3a4adff35.zip
Cleanup error reporting
The error message reported is overlay complicated and the added test does not really help the user. Currently the error looks like: podman run -p 80:80 fedora echo hello Error: failed to expose ports via rootlessport: "cannot expose privileged port 80, you might need to add "net.ipv4.ip_unprivileged_port_start=0" (currently 1024) to /etc/sysctl.conf, or choose a larger port number (>= 1024): listen tcp 0.0.0.0:80: bind: permission denied\n" After this change ./bin/podman run -p 80:80 fedora echo hello Error: cannot expose privileged port 80, you might need to add "net.ipv4.ip_unprivileged_port_start=0" (currently 1024) to /etc/sysctl.conf, or choose a larger port number (>= 1024): listen tcp 0.0.0.0:80: bind: permission denied Control chars have been eliminated. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
-rw-r--r--libpod/networking_linux.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/libpod/networking_linux.go b/libpod/networking_linux.go
index 4bc9381bd..5aed630de 100644
--- a/libpod/networking_linux.go
+++ b/libpod/networking_linux.go
@@ -556,7 +556,7 @@ func (r *Runtime) setupRootlessPortMappingViaRLK(ctr *Container, netnsPath strin
if stdoutStr != "" {
// err contains full debug log and too verbose, so return stdoutStr
logrus.Debug(err)
- return errors.Errorf("failed to expose ports via rootlessport: %q", stdoutStr)
+ return errors.Errorf("rootlessport " + strings.TrimSuffix(stdoutStr, "\n"))
}
return err
}