diff options
author | Matthew Heon <matthew.heon@pm.me> | 2020-05-20 18:19:06 -0400 |
---|---|---|
committer | Matthew Heon <matthew.heon@pm.me> | 2020-05-20 18:24:56 -0400 |
commit | 66cae3209ec362cc6fb663dec742cf0514aa9af8 (patch) | |
tree | 4f0bfde574c55d26eef141792faeab8171ff093d /cmd/podman/pods/top.go | |
parent | e8e5a5f96e0b5d915baeeb0915cc0ca788b70e64 (diff) | |
download | podman-66cae3209ec362cc6fb663dec742cf0514aa9af8.tar.gz podman-66cae3209ec362cc6fb663dec742cf0514aa9af8.tar.bz2 podman-66cae3209ec362cc6fb663dec742cf0514aa9af8.zip |
Fix build on OS X
We disabled the OS X and Windows cross-building tests. This,
predictably, led us to regress a bit in our ability to build for
both of these.
This fixes the build on OS X and fixes one obvious Windows bug.
Unfortunately, we're dragging in all of `pkg/spec` somewhere on
Windows, and things are blowing up spectacularly because of it
(plus a few uses of the `syscall` package in the bindings).
I've giving up for the day. This fixes OS X, but does not fully
enable the cross-build CI (need Windows fixes for that).
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Diffstat (limited to 'cmd/podman/pods/top.go')
-rw-r--r-- | cmd/podman/pods/top.go | 20 |
1 files changed, 14 insertions, 6 deletions
diff --git a/cmd/podman/pods/top.go b/cmd/podman/pods/top.go index 9cf2bd525..ba1efb638 100644 --- a/cmd/podman/pods/top.go +++ b/cmd/podman/pods/top.go @@ -9,17 +9,15 @@ import ( "github.com/containers/libpod/cmd/podman/registry" "github.com/containers/libpod/pkg/domain/entities" - "github.com/containers/psgo" + "github.com/containers/libpod/pkg/util" "github.com/pkg/errors" "github.com/spf13/cobra" ) var ( - topDescription = fmt.Sprintf(`Specify format descriptors to alter the output. + topDescription = `Specify format descriptors to alter the output. - You may run "podman pod top -l pid pcpu seccomp" to print the process ID, the CPU percentage and the seccomp mode of each process of the latest pod. - Format Descriptors: - %s`, strings.Join(psgo.ListDescriptors(), ",")) + You may run "podman pod top -l pid pcpu seccomp" to print the process ID, the CPU percentage and the seccomp mode of each process of the latest pod.` topOptions = entities.PodTopOptions{} @@ -43,6 +41,12 @@ func init() { Parent: podCmd, }) + descriptors, err := util.GetContainerPidInformationDescriptors() + if err == nil { + topDescription = fmt.Sprintf("%s\n\n Format Descriptors:\n %s", topDescription, strings.Join(descriptors, ",")) + topCommand.Long = topDescription + } + flags := topCommand.Flags() flags.SetInterspersed(false) flags.BoolVar(&topOptions.ListDescriptors, "list-descriptors", false, "") @@ -56,7 +60,11 @@ func init() { func top(cmd *cobra.Command, args []string) error { if topOptions.ListDescriptors { - fmt.Println(strings.Join(psgo.ListDescriptors(), "\n")) + descriptors, err := util.GetContainerPidInformationDescriptors() + if err != nil { + return err + } + fmt.Println(strings.Join(descriptors, "\n")) return nil } |